feat: create BookingHistoryViewerService to combine audit logs with routing form submissions #26045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outing form submissions Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…-viewer-service-1766126882
- Updated the booking logs view to use the new getBookingHistory query instead of getAuditLogs. - Introduced DisplayBookingAuditLog type for improved clarity in BookingAuditViewerService. - Refactored BookingHistoryViewerService to utilize the new DisplayBookingAuditLog type and added sorting functionality for history logs. - Adjusted related types and methods to ensure consistency across services.
- Consolidated type exports and imports from the features library for better organization. - Removed redundant type definitions and functions in zod.ts, findFieldValueByIdentifier.ts, getFieldIdentifier.ts, and parseRoutingFormResponse.ts. - Introduced new utility functions for handling field responses and parsing routing form responses. - Improved type safety and clarity across routing form response handling.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
hariombalhara
commented
Dec 23, 2025
Member
Author
There was a problem hiding this comment.
Moved code from @calcom/app-store
hariombalhara
commented
Dec 23, 2025
Member
Author
There was a problem hiding this comment.
Moved code from @calcom/app-store
hariombalhara
commented
Dec 23, 2025
Member
Author
There was a problem hiding this comment.
Moved code from @calcom/app-store
hariombalhara
commented
Dec 23, 2025
Member
Author
There was a problem hiding this comment.
Moved code from @calcom/app-store
hariombalhara
commented
Dec 23, 2025
Member
Author
There was a problem hiding this comment.
Moved code from @calcom/app-store
graphite-app
bot
added
enterprise
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 22 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/trpc/server/routers/viewer/bookings/_router.tsx">
<violation number="1" location="packages/trpc/server/routers/viewer/bookings/_router.tsx:111">
P2: The route name was changed from `getAuditLogs` to `getBookingHistory`, but the PR description claims backward compatibility was maintained by keeping the route name as `getAuditLogs`. If there are existing consumers of this tRPC endpoint, this will be a breaking change. Either:
1. Keep the original route name `getAuditLogs` (or add an alias) to maintain backward compatibility
2. Update the PR description to reflect that this is a breaking change</violation>
</file>
<file name="packages/features/booking-audit/lib/service/BookingHistoryViewerService.ts">
<violation number="1" location="packages/features/booking-audit/lib/service/BookingHistoryViewerService.ts:79">
P1: The `uniqueId` variable already contains the `id: ` prefix, causing double prefixing in the `id` field (`id: id: form-submission-X`) and inconsistent prefixing in `operationId` (`operationId: id: form-submission-X`). Remove the `id: ` prefix from `uniqueId`.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
packages/features/booking-audit/lib/service/BookingHistoryViewerService.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Contributor
E2E results are ready! |
This was referenced Jan 5, 2026
volnei
previously approved these changes
Jan 5, 2026
Member
Author
Merge activity
|
…-viewer-service-1766126882
Member
Author
|
@volnei @Udit-takkar Resolved a small conflict here. So, need a reapproval |
volnei
approved these changes
Jan 5, 2026
kodiakhq
bot
deleted the
devin/booking-history-viewer-service-1766126882
branch
Pallava-Joshi
pushed a commit
to Pallava-Joshi/cal.com
that referenced
this pull request
Jan 7, 2026
…outing form submissions (calcom#26045) * feat: create BookingHistoryViewerService to combine audit logs with routing form submissions Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * refactor(booking): rename audit log query and enhance type safety - Updated the booking logs view to use the new getBookingHistory query instead of getAuditLogs. - Introduced DisplayBookingAuditLog type for improved clarity in BookingAuditViewerService. - Refactored BookingHistoryViewerService to utilize the new DisplayBookingAuditLog type and added sorting functionality for history logs. - Adjusted related types and methods to ensure consistency across services. * refactor(routing-forms): streamline imports and enhance type definitions - Consolidated type exports and imports from the features library for better organization. - Removed redundant type definitions and functions in zod.ts, findFieldValueByIdentifier.ts, getFieldIdentifier.ts, and parseRoutingFormResponse.ts. - Introduced new utility functions for handling field responses and parsing routing form responses. - Improved type safety and clarity across routing form response handling. * fix: remove double prefix from uniqueId in form submission entry Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * 1c97f9c (calcom#26453) --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a new
BookingHistoryViewerServicethat combines booking audit logs with routing form submission data to provide a complete chronological history of a booking. This service replaces the direct usage ofBookingAuditViewerServicein the tRPC handler.Changes:
BookingHistoryViewerServicethat injectsBookingAuditViewerServiceandRoutingFormResponseRepositoryRoutingFormResponseRepository(tokens and module)booking-logs-view.tsxto use the newgetBookingHistoryendpoint@calcom/app-storeto@calcom/features/routing-forms/lib/Updates since last revision
uniqueIdgeneration for form submission entries (was producingid: id: form-submission-X, now correctly producesform-submission-X)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Human Review Checklist
createFormSubmissionEntrymatches whatbooking-logs-view.tsxexpectstype: "RECORD_CREATED",action: "CREATED",source: "WEBAPP",actor.type: "GUEST"- are these semantically appropriate for form submissions?getAuditLogstogetBookingHistoryis acceptableChecklist
Link to Devin run: https://app.devin.ai/sessions/88c554ef0ed04e6d9b79985709d48552
Requested by: @hariombalhara (hariom@cal.com)