Skip to content

Conversation

@hariombalhara
Copy link
Member

What does this PR do?

Adds react-awesome-query-builder as an explicit dependency to the @calcom/features package.

This dependency is required because several files in @calcom/features import from react-awesome-query-builder:

  • packages/features/Segment.tsx - imports Query, Builder, Utils as QbUtils
  • packages/features/routing-forms/lib/findTeamMembersMatchingAttributeLogic.ts - imports types and Utils as QbUtils

The version 5.1.2 matches what's already used in packages/app-store/routing-forms/package.json to maintain consistency across the monorepo.

Follow-up to PR #26045 discussion.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. N/A - dependency addition only.

How should this be tested?

This is a dependency addition only. Verification:

  1. Confirm the package builds successfully
  2. Confirm the version 5.1.2 matches the version used in packages/app-store/routing-forms/package.json

Human Review Checklist

  • Verify the yarn.lock changes are as expected (note: some peerDependencies changes may be present due to the base branch state)
  • Confirm version 5.1.2 is consistent with the rest of the monorepo

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Link to Devin run: https://app.devin.ai/sessions/0f2a3e8264d846a0908980acf5d01bef
Requested by: hariom@cal.com (@hariombalhara)

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
cal Ignored Ignored Jan 5, 2026 10:43am
cal-companion Ignored Ignored Preview Jan 5, 2026 10:43am
cal-eu Ignored Ignored Jan 5, 2026 10:43am

@devin-ai-integration devin-ai-integration bot force-pushed the devin/add-raqb-features-dep-for-26045-1767608917 branch from 3420dba to 1c97f9c Compare January 5, 2026 10:35
@hariombalhara hariombalhara force-pushed the devin/add-raqb-features-dep-for-26045-1767608917 branch from 1c97f9c to d5fb730 Compare January 5, 2026 10:42
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Jan 5, 2026
@hariombalhara hariombalhara marked this pull request as ready for review January 5, 2026 10:43
@hariombalhara hariombalhara requested a review from a team as a code owner January 5, 2026 10:43
@graphite-app graphite-app bot added enterprise area: enterprise, audit log, organisation, SAML, SSO core area: core, team members only labels Jan 5, 2026
@graphite-app graphite-app bot requested a review from a team January 5, 2026 10:43
@hariombalhara hariombalhara merged commit 950c95b into devin/booking-history-viewer-service-1766126882 Jan 5, 2026
15 of 16 checks passed
@hariombalhara hariombalhara deleted the devin/add-raqb-features-dep-for-26045-1767608917 branch January 5, 2026 10:43
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

kodiakhq bot pushed a commit that referenced this pull request Jan 5, 2026
…outing form submissions (#26045)

* feat: create BookingHistoryViewerService to combine audit logs with routing form submissions

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

* refactor(booking): rename audit log query and enhance type safety

- Updated the booking logs view to use the new getBookingHistory query instead of getAuditLogs.
- Introduced DisplayBookingAuditLog type for improved clarity in BookingAuditViewerService.
- Refactored BookingHistoryViewerService to utilize the new DisplayBookingAuditLog type and added sorting functionality for history logs.
- Adjusted related types and methods to ensure consistency across services.

* refactor(routing-forms): streamline imports and enhance type definitions

- Consolidated type exports and imports from the features library for better organization.
- Removed redundant type definitions and functions in zod.ts, findFieldValueByIdentifier.ts, getFieldIdentifier.ts, and parseRoutingFormResponse.ts.
- Introduced new utility functions for handling field responses and parsing routing form responses.
- Improved type safety and clarity across routing form response handling.

* fix: remove double prefix from uniqueId in form submission entry

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

* 1c97f9c (#26453)

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Pallava-Joshi pushed a commit to Pallava-Joshi/cal.com that referenced this pull request Jan 7, 2026
…outing form submissions (calcom#26045)

* feat: create BookingHistoryViewerService to combine audit logs with routing form submissions

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

* refactor(booking): rename audit log query and enhance type safety

- Updated the booking logs view to use the new getBookingHistory query instead of getAuditLogs.
- Introduced DisplayBookingAuditLog type for improved clarity in BookingAuditViewerService.
- Refactored BookingHistoryViewerService to utilize the new DisplayBookingAuditLog type and added sorting functionality for history logs.
- Adjusted related types and methods to ensure consistency across services.

* refactor(routing-forms): streamline imports and enhance type definitions

- Consolidated type exports and imports from the features library for better organization.
- Removed redundant type definitions and functions in zod.ts, findFieldValueByIdentifier.ts, getFieldIdentifier.ts, and parseRoutingFormResponse.ts.
- Introduced new utility functions for handling field responses and parsing routing form responses.
- Improved type safety and clarity across routing form response handling.

* fix: remove double prefix from uniqueId in form submission entry

Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>

* 1c97f9c (calcom#26453)

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants