refactor: move useAppsData to features #28098
Merged
Ryukemeister merged 4 commits intomainfrom Mar 12, 2026
Merged
Conversation
…sPlatform prop in DisconnectIntegrationModal Co-Authored-By: rajiv@cal.com <sahalrajiv6900@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rajiv@cal.com <sahalrajiv6900@gmail.com>
This was referenced Feb 20, 2026
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
eunjae-lee
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part 1 of 3 PRs to decouple Apps Components and eliminate circular dependencies between
@calcom/atoms,@calcom/web, and@calcom/features.This PR breaks two specific dependency cycles:
atoms → web(useAppsData):EventPaymentsTabPlatformWrapperin atoms importeduseAppsDatafrom@calcom/web. MoveduseAppsDatato@calcom/features/apps/hooks/useAppsData.ts— its only dependencies arereact-hook-form,@calcom/app-storetypes, and@calcom/featurestypes, all valid at the features layer.features → atoms(useIsPlatform):DisconnectIntegrationModalin features importeduseIsPlatformfrom@calcom/atoms. Replaced with an explicitisPlatformprop (defaults tofalse). Atoms caller now passesisPlatform={true}.Changes
packages/features/apps/hooks/useAppsData.ts(moved fromapps/web/modules/apps/hooks/)DisconnectIntegrationModal— removeduseIsPlatformimport, addedisPlatformpropEventPaymentsTabPlatformWrapper(atoms),EventAppsTab(web),EventTypeAppSettingsWrapper(web)isPlatform={true}toDisconnectIntegrationModalusage inConferencingAppsViewPlatformWrapper(atoms)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This is a pure refactor with no functional changes. Existing behavior should remain identical:
yarn type-check:ci --force— should pass (pre-existing embed-react errors unrelated)TZ=UTC yarn test— existing tests should passEnvironment variables: None required
Test data: Any user with installed apps (Stripe, Zoom, Google Meet, etc.)
Human Review Checklist
useAppsDatalogic is identical after move (compare old vs new file)isPlatformprop default (false) correctly replacesuseIsPlatform()for web callersisPlatform={true}where neededapps/web/modules/apps/hooks/useAppsData.tsif no other references existConferencingAppsViewPlatformWrapper.tsxwill be fixed in follow-up PRsLink to Devin run: https://app.devin.ai/sessions/3381ce426a1748ba909e440d155433a1
Requested by: @Ryukemeister