refactor: move AppList to features with slot props #28100
Merged
Ryukemeister merged 6 commits intomainfrom Mar 12, 2026
Merged
Conversation
… + fix broken type import Co-Authored-By: rajiv@cal.com <sahalrajiv6900@gmail.com>
…rd switcher Co-Authored-By: rajiv@cal.com <sahalrajiv6900@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rajiv@cal.com <sahalrajiv6900@gmail.com>
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
AppList to features with slot props
eunjae-lee
previously approved these changes
Mar 11, 2026
Contributor
Devin AI is resolving merge conflictsThis PR has merge conflicts with the Devin will:
If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself. |
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
E2E results are ready! |
eunjae-lee
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part 3 of 3 PRs to decouple Apps Components and eliminate circular dependencies between
@calcom/atoms,@calcom/web, and@calcom/features. (See PR #28098 for Part 1 and PR #28099 for Part 2.)This PR breaks the remaining dependency violations:
atoms → web:ConferencingAppsViewPlatformWrapperimportedAppListfrom@calcom/web→ now imports from@calcom/featuresweb → atoms:AppListCard.tsximporteduseIsPlatformfrom@calcom/atoms→ deleted; consumers now pass the correct variant directlyfeatures → trpc:AppListimportedRouterOutputsfrom@calcom/trpc→ replaced with explicit types (ConnectedAppsfrom app-store,DefaultConferencingAppfrom prisma/zod-utils)Changes
AppList.tsx→packages/features/apps/components/AppList.tsxwith explicit types replacingRouterOutputsand a newAppListCardComponentslot propAppListCardPlatformWrapper.tsx→packages/platform/atoms/connect/conferencing-apps/(platform-specific code lives in atoms)apps/web/modules/apps/components/AppListCard.tsx(the dynamic switcher usinguseIsPlatform)AppListfrom features and pass the rightAppListCardComponentvariant:AppListCardWebWrapperAppListCardPlatformWrapperUpdates since last revision
datatype: changeddata: { items: ConnectedApps }todata: ConnectedAppssinceConnectedAppsalready has the shape{ items: ... }. CI type checks now pass.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This is a pure refactor with no intended functional changes. Verify:
/apps/installed/conferencing— the installed apps list should render identically to beforeAppListCardWebWrapperyarn type-check:ci --force— passes ✅Environment variables: None required
Test data: Any user with installed conferencing apps (Zoom, Google Meet, Office 365 Video)
Human Review Checklist
ConnectedAppsfrom@calcom/app-store/_utils/getConnectedAppsexactly matches the shape ofRouterOutputs["viewer"]["apps"]["integrations"]. The tRPC router might add/transform fields that aren't in the raw return type.DefaultConferencingAppfrom@calcom/prisma/zod-utilsexactly matchesRouterOutputs["viewer"]["apps"]["getUsersDefaultConferencingApp"]AppListCardComponentprop is passed in all consumers ofAppListLink to Devin run: https://app.devin.ai/sessions/3381ce426a1748ba909e440d155433a1
Requested by: @Ryukemeister