Fixes 400 being thrown for NaN on disabling seats#3945
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
left a comment
There was a problem hiding this comment.
Good solution @sean-brydon but I have some Qs. Why is seatPerTimeSlot is returning as NaN in the first place? My guess is that this is coming upstream in the flow. We can either, prevent the NaN from happening earlier instead of patching down here. My suspicion is a faulty parseInt or something like that.
@zomars Just had a look into this and it appears that we are sending null over the form but for some reason its getting translated to a NaN - looking into this more but I can't seem to figure out why this is happening |
whats the step forward? merge or investigate more= |
|
@zomars after digging into this this morning I got nowhere - we send over null via rhf and it ends up in the form state as NaN. Not 100% sure as the type is set as |
|
Would it be possible to deploy this, so the bug is fixed, and keep looking for a better solution? |
zomars
left a comment
There was a problem hiding this comment.
Merging for now but this general form needs a major refactor
What does this PR do?
Fixes #3944
Environment: Staging(main branch) / Production
Type of change