Skip to content

Add embed tests in CI#2887

Merged
hariombalhara merged 41 commits intomainfrom
tests/ci-embed
May 30, 2022
Merged

Add embed tests in CI#2887
hariombalhara merged 41 commits intomainfrom
tests/ci-embed

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented May 26, 2022 •
edited
Loading

What does this PR do?

Right now tests are running with --update-snapshots and thus they aren't verifying the snapshots but they are still useful in capturing bugs.

Followup

  • Allow running the build manually and updating the snapshots and committing them to the main(using a PR)
  • Run the tests without update-snapshots after that.

Type of change

  • Tests

@vercel
Copy link
Copy Markdown

vercel bot commented May 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview May 30, 2022 at 4:35PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) May 30, 2022 at 4:35PM (UTC)
swagger ⬜️ Ignored (Inspect) May 30, 2022 at 4:35PM (UTC)
ui ⬜️ Ignored (Inspect) May 30, 2022 at 4:35PM (UTC)

@hariombalhara hariombalhara force-pushed the tests/ci-embed branch 2 times, most recently from 6ed816e to 082b5f9 Compare May 26, 2022 12:08
@hariombalhara
Copy link
Copy Markdown
Member Author

hariombalhara commented May 26, 2022

@zomars is there a way to make embed tests a non blocker for merge.

@zomars
Copy link
Copy Markdown
Contributor

zomars commented May 26, 2022

@zomars is there a way to make embed tests a non blocker for merge.

You need to name it differently to Testing 14.x and ubuntu-latest Since that's a required check.

zomars
zomars reviewed May 26, 2022
View reviewed changes
Comment thread .github/workflows/e2e-embed.yml Outdated
jobs:
test:
timeout-minutes: 20
name: Testing ${{ matrix.node }} and ${{ matrix.os }}
Copy link
Copy Markdown
Contributor

@zomars zomars May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this name to make it non-blocking @hariombalhara

zomars
zomars reviewed May 26, 2022
View reviewed changes
Comment thread .github/workflows/e2e-embed.yml Outdated
branches:
- main
paths-ignore:
- public/static/locales/**
Copy link
Copy Markdown
Contributor

@zomars zomars May 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to update these paths so this test only runs when embed-related code changes.

Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip

@hariombalhara hariombalhara force-pushed the tests/ci-embed branch 2 times, most recently from a89cc20 to 906c983 Compare May 27, 2022 05:11
@hariombalhara hariombalhara requested a review from emrysal May 28, 2022 07:09
zomars
zomars approved these changes May 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if you feel this is ready @hariombalhara

@zomars
Copy link
Copy Markdown
Contributor

zomars commented May 30, 2022 •
edited
Loading

Seems like the tests are running and failing @hariombalhara https://github.com/calcom/cal.com/runs/6659342595?check_suite_focus=true

@zomars zomars mentioned this pull request May 30, 2022
Merged
@hariombalhara
Copy link
Copy Markdown
Member Author

hariombalhara commented May 31, 2022

@zomars It is fixed in #2929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal Awaiting requested review from emrysal

1 more reviewer

@zomars zomars zomars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hariombalhara @zomars @PeerRich