Skip to content

vimcal app#5791

Merged
PeerRich merged 18 commits intomainfrom
5785-cal-502-vimcal-app
Dec 15, 2022
Merged

vimcal app#5791
PeerRich merged 18 commits intomainfrom
5785-cal-502-vimcal-app

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Nov 29, 2022

CleanShot 2022-12-14 at 13 59 13

TODO:

  • dont show calendar apps with external redirect in /getting-started onboarding calendar step

@PeerRich PeerRich linked an issue Nov 29, 2022 that may be closed by this pull request
@linear
Copy link
Copy Markdown

linear Bot commented Nov 29, 2022

CAL-502 vimcal app

null

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 8:43AM (UTC)

Comment thread packages/app-store/vimcal/api/add.ts
Comment thread apps/web/pages/getting-started/[[...step]].tsx Outdated
@PeerRich PeerRich marked this pull request as ready for review December 14, 2022 16:12
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Dec 14, 2022
@PeerRich PeerRich enabled auto-merge (squash) December 14, 2022 16:12
const allowedMultipleInstalls = categories.indexOf("calendar") > -1;
// variant not other allows, an app to be shown in calendar category without requiring an actual calendar connection e.g. vimcal
// Such apps, can only be installed once.
const allowedMultipleInstalls = categories.indexOf("calendar") > -1 && variant !== "other";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @leog for review

Comment thread apps/web/pages/getting-started/[[...step]].tsx Outdated
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@PeerRich PeerRich merged commit 3456cc5 into main Dec 15, 2022
@PeerRich PeerRich deleted the 5785-cal-502-vimcal-app branch December 15, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-502] vimcal app

2 participants