Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
requested review from
a team,
emrysal and
leog
and removed request for
leog
| { | ||
| source: "/booking/direct/:action/:email/:bookingUid/:oldToken", | ||
| destination: "/api/link?action=:action&email=:email&bookingUid=:bookingUid&oldToken=:oldToken", | ||
| permanent: true, | ||
| }, |
There was a problem hiding this comment.
So old links gets redirected
| async function sessionGetter() { | ||
| return { | ||
| user: { | ||
| id: userId, |
There was a problem hiding this comment.
This comes from the encrypted token
zomars
added
♻️ autoupdate
| attendee.timeZone = dynamic; | ||
| attendee.language = dynamic; | ||
| } | ||
| body.payload.organizer.id = dynamic; |
There was a problem hiding this comment.
We now need this organizer id to generate the token
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
It looks good to me, nice cleanup, have a look at my comments and see if there's any merrit to my thought - will turn off automerge so you can eval.
github-actions
Bot
removed
♻️ autoupdate
leog
left a comment
leog
left a comment
There was a problem hiding this comment.
LGTM. Found some NITs comparing to old approach:
- When an error happens (invalid token, booking already confirmed or rejected), we should redirect to page 500 with an error query param with the message
- I think we should remove the following section of the booking page for this feature
Agreed, we can follow up tho. Not critical IMO.
We can discuss this. I don't think is that much of an issue. |
Agreed, which is why I approved it anyway. NITs shouldn't stop a PR.
Not an issue, it just looks weird, an oversight. The person accepting/rejecting already has an account, it just looks sloppy IMO. |
* Booking confirmation link improvements * Cleanup * Update webhooks payload * Removing unneeded dependency * Feedback * Matches enum style to rest of codebase Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Leo Giovanetti <hello@leog.me>
4 participants
What does this PR do?
/api/linkTo do (maybe)
Type of change
How should this be tested?