Team webhooks#8917
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/22/2023 09:11:35pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2fcc335 Started: 05/22/2023 09:02:22pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 302 runsfailed over last 7 days |
85.10% (257)257 / 302 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
9.09% (16)16 / 176 runsfailed over last 7 days |
30.68% (54)54 / 176 runsflaked over last 7 days |
|
Editing an EventType webhook throws error even if I don't change the webhook URL |
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
Left some comments. Only one is an actual bug(EventType Webhook Edit) others are just nits.
Also, the authorization logic is quite tricky right now(with duplication). I would review that tomorrow and then approve.
| const userBelongsToTeam = | ||
| eventType.team && | ||
| eventType.team.members.some( | ||
| (membership) => | ||
| membership.userId === ctx.user.id && | ||
| (membership.role === MembershipRole.ADMIN || membership.role === MembershipRole.OWNER) | ||
| ); | ||
| if (!userBelongsToTeam) { | ||
| throw new TRPCError({ | ||
| code: "UNAUTHORIZED", | ||
| }); | ||
| } |
There was a problem hiding this comment.
We can remove duplication like this
assertPartOfTeamWithRequiredAccessLevel()
|
@alannnc and @hariombalhara Thank you for the feedback 🙏 I addressed most of it already (@hariombalhara I still need to take a look at that error when editing). I will also do one more round of testing to make sure the clean-up didn't break anything |
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Nice work! @CarinaWolli @alannnc @hariombalhara 🙏🏽
5 participants
What does this PR do?
Admin/Owner:
Member:
Fixes #8815
Type of change
How should this be tested?