feat: expose daemon artifact inventory by szdziedzic · Pull Request #1020 · callstack/agent-device

szdziedzic · 2026-07-02T10:36:17Z

Summary

add an authenticated GET /artifacts daemon endpoint that lists pending downloadable artifacts with filename, MIME type, size, creation time, and expiry time
support hosted-session retained artifacts via AGENT_DEVICE_RETAIN_ARTIFACTS=1
archive directory artifacts as .tar.gz downloads, including .trace bundles, while preserving the existing one-shot consume behavior for normal downloads
allow the daemon proxy to forward artifact inventory requests and downloads

Details

The inventory endpoint is tenant-filtered and best-effort: missing artifacts are cleaned up, and directory artifacts that fail to archive are skipped from inventory without blocking other artifacts. Direct downloads still surface artifact-specific errors.

Directory archives are cached per tracked artifact and concurrent callers share the same in-flight archive operation. Cached archives are cleaned up with the tracked artifact.

Normal downloads still consume their artifact inventory entry even when the tracked source path was registered with deleteAfterDownload: false; that flag only controls whether cleanup removes the backing path. When the daemon starts with AGENT_DEVICE_RETAIN_ARTIFACTS=1, every direct GET /artifacts/:id download stays retained instead. This lets EAS-style hosted sessions keep tunneling the raw daemon port while preventing user downloads from consuming artifacts before a live upload poller can upload them.

Test plan

pnpm vitest run --project unit src/daemon/__tests__/http-server-artifacts.test.ts src/__tests__/daemon-entrypoint.test.ts src/__tests__/daemon-proxy.test.ts src/utils/__tests__/args.test.ts src/utils/__tests__/daemon-client.test.ts
pnpm vitest run --project provider-integration test/integration/provider-scenarios/daemon-http-server.test.ts test/integration/provider-scenarios/remote-daemon-client.test.ts
pnpm typecheck
pnpm lint
pnpm format:check
git diff --check

thymikee

I found one artifact lifecycle regression around normal downloads of retained-on-disk artifacts.

thymikee · 2026-07-02T10:53:38Z

+  }
+  return {
+    ...payload,
+    deleteAfterDownload: entry.deleteAfterDownload && options.consume !== false,


This changes the old one-shot tracking behavior for artifacts registered with deleteAfterDownload: false. Previously a normal GET /artifacts/:id always called cleanupDownloadableArtifact, which removed the pending registry entry and only skipped deleting the file when entry.deleteAfterDownload was false. With this return value, the HTTP layer skips cleanup entirely for those entries, so a normal non-retain download remains listed and can be downloaded repeatedly until the timeout. I think the consume decision needs to be separate from the file-delete decision, e.g. normal downloads still remove the pending entry while deleteAfterDownload only controls removal of the backing path.

Good catch, thanks. You were right: this was conflating two separate lifecycles.

I updated the implementation so completed HTTP downloads use consumeAfterDownload to decide whether to remove the artifact from the pending inventory, while deleteAfterDownload only controls whether cleanup removes the backing source path.

I also added a regression test for deleteAfterDownload: false: a normal download now consumes the inventory entry but leaves the source file in place. For hosted/EAS sessions, AGENT_DEVICE_RETAIN_ARTIFACT_DOWNLOADS=1 sets consumeAfterDownload: false, so user downloads and the EAS poller can both fetch the same artifact.

sjchmiela · 2026-07-02T11:37:02Z


-    const artifact = prepareDownloadableArtifact(artifactId, auth.tenantId);
+    const artifact = await prepareDownloadableArtifact(artifactId, auth.tenantId, {
+      consumeAfterDownload: options.retainArtifactDownloads !== true,


feels kinda weird we thread "retain" through, only to change it to "consume" later

also, there's deleteAfterDownload already?

Agreed, this was weird. I changed it so retainArtifacts stays as an HTTP/server concern, and prepareDownloadableArtifact is back to only preparing the downloadable payload.

deleteAfterDownload keeps its existing meaning: when cleanup runs, should it remove the backing file path? retainArtifacts is separate: should a successful HTTP download skip cleanup entirely so the pending artifact remains available for another consumer.

does it make sense?

sjchmiela · 2026-07-02T11:42:48Z

+      fileName,
+      sizeBytes: fs.statSync(archivePath).size,
+    };
+    if (pendingArtifacts.get(artifactId) !== entry) {


this compares objects? is this expected?

Yes, intentional. entry is the exact map value captured before the async tar; if the artifact was consumed, expired, or re-tracked while archiving, pendingArtifacts.get(artifactId) will no longer be that same object, so we discard the archive instead of attaching it to a stale entry.

Copilot

Pull request overview

This PR adds an authenticated daemon HTTP artifact inventory endpoint (GET /artifacts) and extends artifact handling so directory artifacts can be downloaded as cached .tar.gz archives. It also updates the remote daemon proxy to forward inventory requests and introduces an opt-in retention mode (AGENT_DEVICE_RETAIN_ARTIFACTS=1) so downloads don’t consume artifact entries in hosted-session scenarios.

Changes:

Add GET /artifacts inventory endpoint (tenant-filtered) and enrich artifact download responses with MIME type + size.
Archive directory artifacts as .tar.gz with caching and shared in-flight archive creation.
Extend daemon proxy + client tests to support inventory forwarding and remote artifact downloads; add unit tests for inventory/download semantics and retention mode.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/utils/cli-command-overrides.ts	Updates CLI help text to mention `/artifacts` inventory route support in the proxy.
src/utils/tests/daemon-client.test.ts	Adds a test verifying `downloadRemoteArtifact` hits the correct URL and uses Bearer auth.
src/remote/daemon-proxy.ts	Allows forwarding `GET /artifacts` (and `/artifacts/`) through the proxy.
src/remote/daemon-artifacts.ts	Refactors `downloadRemoteArtifact` params into a named type (no behavior change).
src/daemon/server/http-server.ts	Implements `GET /artifacts` inventory route; enhances download handling (MIME type/length + retention option).
src/daemon/server/daemon-runtime.ts	Threads `AGENT_DEVICE_RETAIN_ARTIFACTS` into the HTTP server creation options.
src/daemon/artifact-tracking.ts	Adds inventory listing, timestamps/expiry, and directory-archive creation/caching/cleanup.
src/daemon/tests/http-server-artifacts.test.ts	New test coverage for inventory filtering, directory archiving behavior, consumption semantics, and retention mode.
src/tests/daemon-proxy.test.ts	Adds proxy test coverage for forwarding `/artifacts` inventory responses.
src/tests/daemon-entrypoint.test.ts	Extends runtime test to validate retain-artifacts behavior via env var.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+function readArtifactId(requestUrl: string | undefined): string {
+  const encoded = readRequestPathname(requestUrl).slice('/artifacts/'.length);
+  if (!encoded || encoded.includes('/')) return '';
+  try {
+    return decodeURIComponent(encoded);
+  } catch {
+    return '';
+  }
+}


+async function waitFor(condition: () => boolean): Promise<void> {
+  for (let attempt = 0; attempt < 20; attempt++) {
+    if (condition()) return;
+    await new Promise((resolve) => setTimeout(resolve, 10));
+  }
+}


+  try {
+    await runCmd(
+      'tar',
+      [
+        'czf',
+        archivePath,
+        '-C',
+        path.dirname(entry.artifactPath),
+        '--',
+        path.basename(entry.artifactPath),
+      ],


szdziedzic · 2026-07-02T13:26:50Z

@thymikee thanks for following up in #1027!

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

thymikee · 2026-07-02T18:14:03Z

Re-check complete: latest head is clean, CI is green, and the only post-approval delta is a test-complexity refactor in daemon-proxy.test.ts with no production behavior change. I do not see remaining blockers; ready for human judgment/merge.

szdziedzic force-pushed the szdziedzic-codex/agent-artifact-inventory branch from fe3e36b to 0bca02f Compare July 2, 2026 10:48

thymikee reviewed Jul 2, 2026

View reviewed changes

szdziedzic force-pushed the szdziedzic-codex/agent-artifact-inventory branch 3 times, most recently from e949769 to 40234df Compare July 2, 2026 11:39

sjchmiela reviewed Jul 2, 2026

View reviewed changes

szdziedzic force-pushed the szdziedzic-codex/agent-artifact-inventory branch 4 times, most recently from d8fef14 to 34b3b5a Compare July 2, 2026 12:13

szdziedzic requested review from sjchmiela and thymikee July 2, 2026 12:14

szdziedzic marked this pull request as ready for review July 2, 2026 12:14

Copilot AI review requested due to automatic review settings July 2, 2026 12:14

Copilot started reviewing on behalf of szdziedzic July 2, 2026 12:15 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

thymikee mentioned this pull request Jul 2, 2026

feat: list daemon artifacts through proxy sessions szdziedzic/agent-device#1

Closed

thymikee approved these changes Jul 2, 2026

View reviewed changes

szdziedzic and others added 2 commits July 2, 2026 19:33

feat: expose daemon artifact inventory

3f93d2b

refactor: isolate daemon artifact HTTP routes

e527d3b

Copilot AI review requested due to automatic review settings July 2, 2026 17:36

thymikee force-pushed the szdziedzic-codex/agent-artifact-inventory branch from a5521ce to e527d3b Compare July 2, 2026 17:36

Copilot AI reviewed Jul 2, 2026

test: reduce proxy artifact test complexity

672a665

thymikee mentioned this pull request Jul 2, 2026

feat: list daemon artifacts through proxy sessions #1027

Merged

thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Jul 2, 2026

thymikee merged commit 08594fc into callstack:main Jul 2, 2026
17 checks passed

szdziedzic mentioned this pull request Jul 2, 2026

[eas-cli] Upload agent-device session artifacts expo/eas-cli#3939

Draft

Uh oh!

Conversation

szdziedzic commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Test plan

Uh oh!

thymikee left a comment

Choose a reason for hiding this comment

Uh oh!

thymikee Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

szdziedzic Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

sjchmiela Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

sjchmiela Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

szdziedzic Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjchmiela Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

thymikee Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

szdziedzic commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

thymikee commented Jul 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

szdziedzic commented Jul 2, 2026 •

edited

Loading