fix: align Maestro swipe semantics across platforms#1179
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
Member
Author
Review — 🟢 SHIP-WITH-NITSThe substantive change is a clean one-line guard in Verified:
Nits:
Minimal, correct, no falsy-zero trap, no regression of the earlier gesture stabilization. 🤖 Generated with Claude Code |
daff7d7 to
bb51342
Compare
Member
Author
|
Addressed the three nits from the earlier review on the current head:
No unresolved inline review threads remain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve authored Maestro percentage coordinates through a shared core frame-bounds helper and route directional screen swipes through core gesture presets.
Match Maestro iOS synthesized swipe timing while preserving continuous timing for pan and fling; keep non-idempotent assertion recovery Android-only.
Delegate Android helper builds to the clean packaging scripts and document helper-backed Android verification.
Validation
pnpm check:quick,pnpm check:tooling,pnpm check:fallow --base origin/main,pnpm build,pnpm build:android, andpnpm build:xcuitest.