test: add Android full emulator coverage - #1484
Conversation
bfca2fd to
d8de04d
Compare
94e47ce to
8538b7b
Compare
|
PR #1484 is not ready at exact head
No |
19a1f55 to
d835e27
Compare
|
Exact-head review found two blockers:
The manifest/evidence machinery is otherwise structurally meaningful, but the expanded live-scenario scope goes beyond #1426’s original guardrail and needs explicit coordination/approval after the stack is repaired. |
c6a379a to
30b8aba
Compare
|
Exact head |
258f65b to
54e3d10
Compare
|
Dependency update: #1482 has now merged, while this draft remains on unchanged head |
8538b7b to
eacf244
Compare
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
|
Re-review at
The previously reported stopped-trace MCP artifact-schema issue is resolved. Static, Coverage, Integration, type/layering, Linux, macOS, and CodeQL are green; Android Release is a confirmed PR-owned failure and device smoke is not complete. |
eacf244 to
84b1416
Compare
|
Addressed the current review findings in 84b1416:\n\n- Registered the Android Expo module as |
thymikee
left a comment
There was a problem hiding this comment.
The full-tier coverage is valuable and the production trace-artifact fix is sound, but exact head 84b1416cf is not ready yet.
- P2 — keep timing diagnostic-only.
test/integration/android-emulator-e2e/live-coverage-report.ts:17-34reintroduces a ten-minute wall-clock assertion into functional coverage. #1482 explicitly removed this because shared emulator load can make a correct journey exceed an arbitrary threshold. The job already has an outer timeout and the report records timings; delete the assertion/import/constant. - P2 — do not rediscover the coverage report by traversal order.
.github/workflows/android.yml:78-79and.github/workflows/replays-nightly.yml:142-143usefind ... | tail -n 1. With multiple artifact directories this can select a stale report—the same defect corrected during #1482. The runner already prints the exact report path and timing summary, so remove both lookups and inline Node programs. - P2 — reuse completed build infrastructure.
.github/workflows/android.yml:75-76repeats the dedicated CLI build and daemon reset immediately above the emulator action. In the nightly workflow,setup-android-replay-hostalready restores or packages and verifies both Android helpers, but line 137 repackages them withpnpm build:android. Keep only work that the emulator genuinely requires.
Exact-head Android/iOS smoke and native Release checks are still running. No ready-for-human label until these regressions are removed and the full Android emulator suite passes.
|
One additional P2 from the tightening pass: |
|
Addressed the latest tightening-pass feedback in 29ab77f:\n\n- Moved event pagination and replay-evidence logic to shared |
|
Re-review at Not ready: both exact-head device smokes reach the fixture but fail on deterministic selector state—iOS cannot find No |
|
Addressed the exact-head device-smoke failures in 9ef5bf1:\n\n- iOS now reveals |
Summary
Extends the Android emulator coverage introduced in #1482 with a full nightly tier while keeping the required smoke tier focused. The full suite adds fixture-observed coverage for:
The coverage report now records the executed tier and a manifest-derived classification rollup, and the nightly lane requires the trusted native fixture produced for the exact head.
Bugs exposed and fixed
trace stopwrote a file but did not publish it as a daemon-managedtrace-log, so it was absent from artifact inventory and could not be downloaded through the artifact endpoint.Builds on merged PR #1482. Scope spans Android E2E scenarios, the Android test fixture, trace artifact publication, and CI orchestration (31 files).
Validation