Skip to content

fix: read Android get text from target field - #1561

Merged
thymikee merged 1 commit into
mainfrom
agent/fix-android-get-text-target-value
Aug 3, 2026
Merged

fix: read Android get text from target field#1561
thymikee merged 1 commit into
mainfrom
agent/fix-android-get-text-target-value

Conversation

@thymikee

@thymikee thymikee commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

Fix Android get text <selector> so the top-level data.text is read from the resolved target field instead of the currently focused sibling.

Android point reads now return the text of the node containing the requested coordinates. Fill verification keeps its separate focused-input and IME handling. Regression coverage fills two distinct EditText fields and asserts each selector returns its own top-level text value.

Validation

  • Focused Android fill/read tests passed.
  • VITEST_MAX_WORKERS=2 pnpm check:affected --run passed formatting, lint, typecheck, layering, Fallow, build, and all 1,419 related tests.
  • Provider-backed Android scenarios passed, including the Android lifecycle suite.
  • Full coverage reached 5,350/5,351 tests; the only failure was an unrelated Apple runner test timing out at the local 5s budget under host load.
  • Live Android emulator validation was not available locally; the updated emulator scenario will run in CI.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.93 MB 1.93 MB 0 B
JS gzip 619.2 kB 619.2 kB +2 B
npm tarball 738.9 kB 738.9 kB +2 B
npm unpacked 2.59 MB 2.59 MB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.4 ms 27.8 ms +0.4 ms
CLI --help 65.8 ms 67.2 ms +1.4 ms

Top changed chunks: no changes in the largest emitted chunks.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 3, 2026
@thymikee

thymikee commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

Reviewed exact head af8194818 — clean and ready for human review.

The production route is covered end to end: get text <selector> resolves a node, dispatches an Android point read at its center, and now returns the text from the point-targeted node rather than a separately focused field. Fill verification retains its distinct focused/IME-aware behavior.

The regression is non-vacuous at both levels: reverting the implementation breaks the two-field hierarchy test, and the Android smoke scenario fills name then email (leaving email focused) before asserting each selector’s top-level data.text. The exact-head Android emulator run confirms smoke:form-input passed, and all current static, integration, coverage, Android smoke, CodeQL, and other required checks are green.

Residual risk is limited to emulator rather than physical-device evidence; this focused correctness fix does not need docs changes.

@thymikee
thymikee marked this pull request as ready for review August 3, 2026 10:09
@thymikee
thymikee merged commit f8617a2 into main Aug 3, 2026
30 checks passed
@thymikee
thymikee deleted the agent/fix-android-get-text-target-value branch August 3, 2026 10:09
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-03 10:09 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant