fix(ios): prevent stale post-gesture snapshot acceptance - #1573
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
Reviewed exact head P1 — the new runner regression is not executed by CI. The implementation otherwise follows the intended post-gesture → snapshot preference → Apple runner route while leaving ordinary/raw snapshots and physical-device ordering unchanged. Before readiness, also rebase/resync onto current Residual risk: no separately authorized cross-vendor review was run. |
|
CI follow-up at the same head: the failed iOS smoke is not on this PR’s changed production route, but it still needs an owner-action rerun before readiness. The failure is a 90s |
Summary
Fixes #1569.
Post-gesture stabilization could accept a baseline-matching XCTest tree after only about six slow captures because the distrust deadline was wall-clock based. Under contention, that left stale checkout geometry in session state.
This addresses both observed causes: slow capture latency no longer reduces the evidence collected, and the runner no longer repeatedly trusts the same XCTest channel when it is the suspected stale source.
Validation