docs: remove superseded architecture proposals and design prototypes (#1478 P7) - #1580
Merged
Conversation
…t symbols #1570 added WAIT_REASONS/WaitReason to packages/contracts/src/wait.ts, which the interaction façade re-exports; #1574's FACADE_SYMBOLS pin was generated on a base without #1570, so check:layering is red on merged main. Adds the two symbols to the pinned list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vXBwStScAV4aGLneCKoma
…1478 P7) The P0-P5 extraction arc is complete and the P6 checkpoint recorded DEFER, so the migration-era documents have no remaining audience: - delete docs/daemon-modularity-proposal.md — superseded by the merged #1478 outcome; the durable rules it deferred to module-interface-principles.md move with that file - delete docs/module-interface-principles.md — its durable kernel (seam maxims, two-adapter rule, consistency disciplines) is folded into CONTEXT.md's 'Principles and their gates'; the aggregate sketch and R7 migration guidance are implemented and enforced by gates - delete docs/maestro-compat-debt-map.md — its file-ownership table predates the packages/maestro extraction and is now misleading; semantics are owned by ADR 0015, boundaries by R10/R11 and the façade symbol pins - delete scripts/prototypes/daemon-boundaries/ and the prototype:* package scripts — the design probes' questions were answered by the landed P4a/P4b/P5 modules and their contract suites - refresh CONTEXT.md's R10 bullet from migration-era counts (30/42, four importers, src/ad-replay pending) to the post-arc state, and record the P6 defer decision - docs/dependency-graph-findings.md is kept: scripts/layering/check.ts and src/client/client-types.ts cite its §0 as the long-form rationale All remaining internal doc links verified to resolve. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vXBwStScAV4aGLneCKoma
14 tasks
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
thymikee
added
the
ready-for-human
thymikee
commented
Aug 4, 2026
thymikee
left a comment
thymikee
left a comment
Member
Author
There was a problem hiding this comment.
Clean readiness review for exact head 90020d90437ecb888e4ac03944ca6d26b7c2d11c.
No actionable diff findings. P7 is faithful to #1478’s ratified cleanup scope; the deletion/reference sweep is clean; and the disclosed WAIT_REASONS/WaitReason façade-pin update is the necessary fix for the red-main guard, with a non-vacuous regression proof. Documentation-only/static-pin validation is appropriate.
Merge condition: iOS and Android smoke lanes were still in progress at the latest refresh. Merge only after both complete successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1478 P7, run per the maintainer-ratified P6 decision of record: one narrow cleanup PR removing migration-era documents whose audience ended when the P0–P5 extraction arc completed and the P6 checkpoint recorded DEFER. No product code, package moves, or opportunistic refactors.
Deleted (2,070 LOC of stale architecture prose and probes):
docs/daemon-modularity-proposal.md— the pre-refactor(daemon): extract replay, Maestro, and replay-test modules #1478 proposal; superseded by the merged outcome and the issue's decision record. Git is the archive.docs/module-interface-principles.md— referenced only by the deleted proposal. Its durable kernel (seam maxims, two-real-adapters rule, no inter-module event bus, the three session-state consistency disciplines) is folded intoCONTEXT.md→ "Principles and their gates" as a Module seams entry; itsScriptPublicationStatesketch and "R7 is the migration ratchet" guidance are implemented (P4a/P4b) and enforced by gates.docs/maestro-compat-debt-map.md— its file-ownership table predates thepackages/maestroextraction and now points at paths that no longer hold (program-ir*.ts,session-test-*.tsat root); semantics are owned by ADR 0015, boundaries by R10/R11 and the façade symbol pins. The one inbound link (CONTEXT.md's selector-contract evidence list) now cites ADR 0015.scripts/prototypes/daemon-boundaries/(four probes + README) and the twoprototype:*package scripts — the probes' two questions were answered by the landed P4a aggregate, P4b coordinator, and P5 engine with their contract suites.Updated:
CONTEXT.md's R10 bullet dropped migration-era counts (R7 30/42, "four importers", "whensrc/ad-replay/first exists") for the post-arc state and records the P6 defer; plus the Module seams addition above.Kept deliberately:
docs/dependency-graph-findings.md—scripts/layering/check.ts:190andsrc/client/client-types.ts:14cite its §0 as the long-form rationale, and the doc itself declares the gate authoritative on disagreement.One non-docs commit, split out and labeled:
ba2449baddsWAIT_REASONS/WaitReasonto the@agent-device/contracts/interactionfaçade pin. This repairs a redcheck:layeringon mergedmain: #1570 added those exports towait.ts(re-exported by the interaction façade) while #1574'sFACADE_SYMBOLSpin was generated on a pre-#1570 base — branch-race skew, red only after both merged. Without it this PR (and every other) cannot go green. Happy to drop the commit if a separate fix is preferred.Per the decision of record, #1478 closes after this merges.
Validation
pnpm check:affected --base origin/main --runpasses end-to-end (format, lint, typecheck, layering incl. the 71-test gate suite and the façade-symbol pins, fallow, replay-compat provenance: 10 mined scripts against released blobs across 6 tags). All internal links in the remaining 35 markdown docs verified to resolve by script. Runtime device validation does not apply: the diff is documentation, throwaway design probes never imported by production code (verified by repo-wide reference sweep), and a two-symbol test-baseline correction.Touched files: 11 (3 docs deleted, 5 prototype files deleted, CONTEXT.md, package.json, facade-symbols.ts). Scope beyond the P7 brief: only the labeled red-main gate repair.
🤖 Generated with Claude Code
https://claude.ai/code/session_017vXBwStScAV4aGLneCKoma
Generated by Claude Code