fix(wait): surface runner restart timeout evidence - #2113
Merged
Conversation
kkkhs
force-pushed
the
agent/wait-restart-diagnostic
branch
from
August 28, 2026 02:47
bfbd74a to
50de77b
Compare
kkkhs
marked this pull request as ready for review
August 28, 2026 02:59
Member
|
Code review is clean at 50de77b. The typed reason is preserved at the runner ownership boundary, the two regression tests fail if their respective implementation seam is reverted, and exact-head CI is green (the two skipped matrix/size entries are not failures). This is not merge-ready yet under docs/agents/pull-requests.md: attach an exact-head iOS Simulator run that deliberately invalidates/restarts the runner during wait and observes wait_runner_restart_exhausted with diagnosticId/logPath. The fake-runner and daemon tests prove the two sides independently, while the iOS smoke job does not exercise the changed failure path. |
thymikee
added
the
ready-for-human
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2103. Keep the caller-supplied wait deadline hard, but preserve an iOS runner restart cause when the capture is cancelled after the restart consumes the wait budget. The wait timeout now reports
wait_runner_restart_exhaustedwith restart/session/log evidence instead ofwait_capture_stalled.Validation
Added a daemon wait regression for the typed restart-exhaustion error and an Apple runner recovery wiring regression for marking failed restart paths. PR-head CI is green, including iOS runner smoke.