refactor: add command definition foundation#513
Merged
Conversation
thymikee
force-pushed
the
codex/command-definition-foundation
branch
from
070f111 to
ac5feca
Compare
|
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a small command-definition foundation for collocating command schema and capability metadata.
Pilot the interaction
typecommand through the new definition by wiring its schema, capability metadata, CLI mapping, and daemon command-name routing from the interaction command module.Tighten
defineCommandaround the shared schema/capability types and remove unusedfamilymetadata so stacked command-definition PRs do not need tautologicalsatisfiesblocks.Touched files: 8. Scope stayed within the command-definition foundation plus one interaction pilot.
Validation
PATH=/Users/thymikee/.nvm/versions/node/v24.13.0/bin:$PATH pnpm format
PATH=/Users/thymikee/.nvm/versions/node/v24.13.0/bin:$PATH pnpm exec vitest run src/commands/interactions/tests/definition.test.ts src/utils/tests/args.test.ts
PATH=/Users/thymikee/.nvm/versions/node/v24.13.0/bin:$PATH pnpm check:fallow
PATH=/Users/thymikee/.nvm/versions/node/v24.13.0/bin:$PATH pnpm check:quick