refactor: collocate session lifecycle command metadata#518
Merged
Conversation
|
thymikee
force-pushed
the
refactor/session-lifecycle-definitions
branch
from
0681aac to
d80425a
Compare
thymikee
force-pushed
the
refactor/session-lifecycle-definitions
branch
from
d80425a to
315081e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collocate session/app lifecycle command schema and capability metadata behind the command-definition foundation.
Centralize lifecycle command names through
PUBLIC_COMMANDS/CLIENT_COMMANDSwhere the CLI router needs those names.Rebased onto current
mainafter #513-#517. Pruned the previousargs.test.tsadditions and covered lifecycle definitions through the existing command-definition registry test instead, keeping Fallow away from unrelated duplicate-heavy parser scenarios.Touched files: 6. Scope stayed within command metadata/CLI routing; no daemon or platform behavior changes.
Validation
PATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm formatPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm exec vitest run src/commands/interactions/__tests__/definition.test.ts src/utils/__tests__/args.test.ts src/core/__tests__/capabilities.test.tsPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm exec fallow audit --changed-since origin/mainPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm check:quick