refactor: add missing types - #16
Merged
Merged
Conversation
Q1w1N
reviewed
Nov 19, 2024
| const refs = Array.isArray(ref) ? ref : [ref]; | ||
|
|
||
| for (const ref of refs) { | ||
| addReferences(references: DocumentReference[]): void { |
Collaborator
There was a problem hiding this comment.
It's not only a naming tweak, but also changes logic from handling single reference to only handling arrays.
Member
Author
There was a problem hiding this comment.
afaik we only called it for arrays
Q1w1N
approved these changes
Nov 19, 2024
Q1w1N
left a comment
Q1w1N
left a comment
Collaborator
There was a problem hiding this comment.
Those changes are good, but let's also add more description in changeset about change in logic for adding references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing exports (Middleware, etc).
Also tweaks
addReferencesnaming.Test plan