fix: handle case when last message is not from user without throwing … - #33
Merged
Conversation
mdjastrzebski
requested changes
Dec 12, 2024
mdjastrzebski
left a comment
mdjastrzebski
left a comment
Member
There was a problem hiding this comment.
modify MockChatModel to capture arguments passed to processMessage. Do not mutate passed messages, make a copy
| if (lastMessage?.role !== 'user') { | ||
| throw new Error('Last message in the "messages" list should be a "UserMessage"'); | ||
| } | ||
| const cleanMessages = ignoreLastAssistantMessage(messages); |
Member
There was a problem hiding this comment.
edge-case: It is technically possible that after ignoreLastAssistantMessage there will be zero messages in the array
Collaborator
Author
There was a problem hiding this comment.
Not really, as this would require AI to trigger itself with a call.
mdjastrzebski
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack app error: UnknownError: Last message in the "messages" list should be a "UserMessage”
Summary
Added logic that removes last messages from AI
Test plan
Tested with websocket
Could add some units though