Skip to content

chore: Add tests for no-constant-binary-expression#270

Merged
thymikee merged 1 commit into
mainfrom
chore/retyui/add-test-for-no-constant-binary-expression-rule
Nov 9, 2023
Merged

chore: Add tests for no-constant-binary-expression#270
thymikee merged 1 commit into
mainfrom
chore/retyui/add-test-for-no-constant-binary-expression-rule

Conversation

@retyui

@retyui retyui commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

Summary

Add test for no-constant-binary-expression rule

Test plan

// comment out `'no-constant-binary-expression': ERROR,` in `node.js`
yarn test
// ^^^ should fail with the next errors:
//  - `Unused eslint-disable directive (no problems were reported from 'no-constant-binary-expression')`

@thymikee thymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example of correct and incorrect would be just enough, can you reduce it? 🙏🏼

@retyui
retyui force-pushed the chore/retyui/add-test-for-no-constant-binary-expression-rule branch from 304d532 to fa10d60 Compare November 9, 2023 15:40
@retyui
retyui requested a review from thymikee November 9, 2023 15:41
@retyui

retyui commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

One example of correct and incorrect would be just enough, can you reduce it? 🙏🏼

no problem

@thymikee
thymikee merged commit ac4bb1c into main Nov 9, 2023
@thymikee
thymikee deleted the chore/retyui/add-test-for-no-constant-binary-expression-rule branch November 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants