build: upgrade example to React Native 0.87 and Strict TypeScript API - #571
Merged
Conversation
Clear inherited source aliases so the example uses Bob-generated package declarations. Source aliases expected a declaration path that was only present after local library typechecks, causing TS6305 in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Upgrade the library example from React Native 0.81 to 0.87.1, with compatible React, native dependencies, and test-app tooling. Update the Android Gradle wrapper and AGP 9 compatibility flags, configure Worklets, and support the namespaced iOS React header layout while retaining the older-header fallback.
Migrate the example to the Strict TypeScript API. Its previous module resolution silently selected the monorepo's RN 0.81 definitions; it now resolves RN 0.87's generated types. Update component refs, derive forwarded color props from TabView, and make the defaulted showLabels prop optional. Include the example in
yarn typecheckand invalidate Turbo's typecheck cache when TypeScript configuration changes. The library's RN development baseline remains unchanged.How to test?
yarn install --immutableyarn typecheck— passes, including the example.yarn lint— passes with three existing warnings.yarn workspace react-native-bottom-tabs-example build:android— native build passes.yarn workspace react-native-bottom-tabs-example build:ios, then build theReactTestAppscheme inapps/example/ios/ReactNativeBottomTabsExample.xcworkspacefor an iOS simulator — native build passes.Verified with agent-device on iOS 18.6 (iPhone 16), iOS 26.5 (iPhone 17 Pro), and Android (Pixel 10 Pro): launch the home page, open Four Tabs, navigate through Article, Albums, and Contacts, and return home. All three targets render successfully without error overlays.