Skip to content

Feat/app example#30

Merged
rgommezz merged 19 commits into
masterfrom
feat/app_example
Aug 14, 2017
Merged

Feat/app example#30
rgommezz merged 19 commits into
masterfrom
feat/app_example

Conversation

@rgommezz

@rgommezz rgommezz commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

Basic Example, nothing fancy.

  • Create example with other APIs
  • Update documentation
  • Double check override in kotlin, make it work in all versions: This is not backwards compatible as per my tests. Kotlin yells with versions prior to 0.47 during the build with the below error:

createJSModules' hides member of supertype 'ReactPackage' and needs 'override' modifier

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 5ebcc9a on feat/app_example into 102e55b on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 662bdc0 on feat/app_example into 102e55b on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling f773fd7 on feat/app_example into 102e55b on master.

@rgommezz
rgommezz requested review from satya164 and zamotany and removed request for zamotany August 9, 2017 23:49
@rgommezz

rgommezz commented Aug 9, 2017

Copy link
Copy Markdown
Contributor Author

@satya164 I don't know how to solve the backwards compatibility with Kotlin, maybe you have some ideas. Apparently the solution works properly in Java. Maybe we can write that boilerplate file in Java and leave the one with the logic with Kotlin?

Also, if you wanna improve the example with different colors/images, feel free to take over this one or create a different one once it's merged. That way, I can in the meantime work on the medium article 🤖

@satya164

Copy link
Copy Markdown
Member

I've never really written kotlin, but I'll give it a try today.

Comment thread .eslintrc Outdated
@@ -0,0 +1,78 @@
{
"parser": "babel-eslint",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use eslint-config-callstack-io instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate issue for that: #29

Comment thread .flowconfig Outdated
; Ignore react-native-mock
.*/node_modules/react-native-mock/*

; Ignore the example app

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't ignore the example app. Using Flow in examples (and tests) makes sure Flow is not broken for our public API.

Comment thread example/package.json Outdated
"preset": "react-native"
},
"eslintConfig": {
"extends": "../.eslintrc"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be necessary since we don't have any overrides

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 1832071 on feat/app_example into 102e55b on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 42f6535 on feat/app_example into 74f57f7 on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling da61127 on feat/app_example into 2baecd3 on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 078449f on feat/app_example into 2baecd3 on master.

@rgommezz
rgommezz merged commit 7e1dfa2 into master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants