Feat/app example#30
Conversation
|
@satya164 I don't know how to solve the backwards compatibility with Kotlin, maybe you have some ideas. Apparently the solution works properly in Java. Maybe we can write that boilerplate file in Java and leave the one with the logic with Kotlin? Also, if you wanna improve the example with different colors/images, feel free to take over this one or create a different one once it's merged. That way, I can in the meantime work on the medium article 🤖 |
|
I've never really written kotlin, but I'll give it a try today. |
| @@ -0,0 +1,78 @@ | |||
| { | |||
| "parser": "babel-eslint", | |||
There was a problem hiding this comment.
We should use eslint-config-callstack-io instead
| ; Ignore react-native-mock | ||
| .*/node_modules/react-native-mock/* | ||
|
|
||
| ; Ignore the example app |
There was a problem hiding this comment.
We shouldn't ignore the example app. Using Flow in examples (and tests) makes sure Flow is not broken for our public API.
| "preset": "react-native" | ||
| }, | ||
| "eslintConfig": { | ||
| "extends": "../.eslintrc" |
There was a problem hiding this comment.
It shouldn't be necessary since we don't have any overrides
Basic Example, nothing fancy.
createJSModules' hides member of supertype 'ReactPackage' and needs 'override' modifier