Migrate from Flow to TS#1114
Merged
Merged
Conversation
…native-paper into feat/flow-to-typescript
…native-paper into feat/flow-to-typescript
Collaborator
|
Should I update the CI config? In order to get green tick |
Collaborator
Author
|
@raajnadar Sure - you can fix it, we can talk on discord in case of questions |
raajnadar
force-pushed
the
feat/flow-to-typescript
branch
from
June 10, 2019 09:10
e15758e to
a248c04
Compare
|
Hey @wojteg1337, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
…native-paper into feat/flow-to-typescript
…native-paper into feat/flow-to-typescript
wojteg1337
force-pushed
the
feat/flow-to-typescript
branch
from
June 25, 2019 12:03
1d50e52 to
ccc5b37
Compare
wojteg1337
force-pushed
the
feat/flow-to-typescript
branch
from
June 25, 2019 12:26
ccc5b37 to
f45667d
Compare
Trancever
approved these changes
Jun 26, 2019
Collaborator
|
Great work! Thanks a lot for the effort you put into this 😊 |
Collaborator
|
Finally this will fix a lot of issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After upgrading Expo/RN version we faced over 700 flow issues, so we decided to migrate to TS
Test plan
yarn typescriptshould pass