Skip to content

feat: added prop to override fontSize#1165

Closed
netbull wants to merge 1 commit into
callstack:masterfrom
netbull:master
Closed

feat: added prop to override fontSize#1165
netbull wants to merge 1 commit into
callstack:masterfrom
netbull:master

Conversation

@netbull
Copy link
Copy Markdown

@netbull netbull commented Jun 30, 2019

Possibility to set the fontSize when "string" is passed as child.

Possibility to set the fontSize when "string" is passed as child.
@callstack-bot
Copy link
Copy Markdown

Hey @netbull, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@jayu
Copy link
Copy Markdown
Contributor

jayu commented Aug 28, 2019

Thank you for the PR but unfortunately, this prop is too specific. In the future, someone would like to have bolded text, different font size, different font family etc. Adding labelStyle prop would be a better approach. See related issue #1273 .

@jayu jayu closed this Aug 28, 2019
@netbull
Copy link
Copy Markdown
Author

netbull commented Aug 28, 2019

@jaysbytes Thanks! That's a valid point. :)

@pan-pawel
Copy link
Copy Markdown
Contributor

@netbull I added PR with labelStyle for button. I will notify you if we add it to paper

@pan-pawel
Copy link
Copy Markdown
Contributor

@netbull we added labelStyle to master, so with next release you will be able to set custom font for button

@netbull
Copy link
Copy Markdown
Author

netbull commented Sep 2, 2019

@pan-pawel that's great! thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants