Skip to content

fix: omit ref in render method of TextInput#1361

Merged
Trancever merged 1 commit intomasterfrom
jaulz/fix-remove-ref
Oct 3, 2019
Merged

fix: omit ref in render method of TextInput#1361
Trancever merged 1 commit intomasterfrom
jaulz/fix-remove-ref

Conversation

@jaulz
Copy link
Copy Markdown
Collaborator

@jaulz jaulz commented Oct 3, 2019

Motivation

Currently, the following warning is printed in console when using a TextInput on web:

TextInput: `ref` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop.

This is because the types say there is a ref prop but in fact the ref prop cannot be accessed at runtime.

Test plan

Open TextInput page in example project for web.

@Trancever Trancever merged commit 1e4b623 into master Oct 3, 2019
@ferrannp ferrannp deleted the jaulz/fix-remove-ref branch October 3, 2019 10:12
@redbluenat
Copy link
Copy Markdown

thanks for solving this issue :) when do you plan to release it :) ?

@Annihil
Copy link
Copy Markdown

Annihil commented Oct 4, 2019

Nice, when is 3.0.0-alpha.6 going to be released? 🙂

@redbluenat
Copy link
Copy Markdown

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants