Skip to content

fix: omit ref in render method of TextInput #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trancever merged 1 commit into from
Oct 3, 2019
Merged

fix: omit ref in render method of TextInput #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/TextInput/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import TextInputOutlined from './TextInputOutlined';
import TextInputFlat from './TextInputFlat';
import { withTheme } from '../../core/theming';
import { RenderProps, State } from './types';
import { Theme } from '../../types';
import { Theme, $Omit } from '../../types';

const BLUR_ANIMATION_DURATION = 180;
const FOCUS_ANIMATION_DURATION = 150;
Expand Down Expand Up @@ -398,8 +398,10 @@ class TextInput extends React.Component<TextInputProps, State> {
}

render() {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { mode, padding, ref: outerRef, ...rest } = this.props;
const { mode, padding, ...rest } = this.props as $Omit<
TextInputProps,
'ref'
>;

return mode === 'outlined' ? (
<TextInputOutlined
Expand Down