Skip to content

Inline Platform.OS checks - #5087

Open
michalfedyna wants to merge 1 commit into
callstack:mainfrom
michalfedyna:chore/inline-platform
Open

Inline Platform.OS checks#5087
michalfedyna wants to merge 1 commit into
callstack:mainfrom
michalfedyna:chore/inline-platform

Conversation

@michalfedyna

Copy link
Copy Markdown

Motivation

Inline Platform.OS code so minifier can remove dead code.

Related issue

Inline Platform.OS code so minifier can remove dead code.

Test plan

Look if replacement was done correctly.

@JKobrynski

Copy link
Copy Markdown
Collaborator

#5078 landed since you opened this and deleted most of what it touches - the isWeb branches in Button and Chip are gone, and Menu on main already inlines the check. That leaves ProgressBar, Tooltip and the example files. Worth rebasing and narrowing it to those? A sweep like this goes stale fast, so better to land it small and soon. @michalfedyna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants