Skip to content

fix(appbar): does not pass any additional props to Searchbar component#972

Merged
jayu merged 1 commit intocallstack:masterfrom
brunohkbx:fix/search-bar
Apr 16, 2019
Merged

fix(appbar): does not pass any additional props to Searchbar component#972
jayu merged 1 commit intocallstack:masterfrom
brunohkbx:fix/search-bar

Conversation

@brunohkbx
Copy link
Copy Markdown
Collaborator

@brunohkbx brunohkbx commented Apr 3, 2019 •
edited
Loading

Fix #605

@callstack-bot
Copy link
Copy Markdown

callstack-bot commented Apr 3, 2019 •
edited
Loading

Hey @brunohkbx, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@brunohkbx brunohkbx force-pushed the fix/search-bar branch 3 times, most recently from 318f767 to f4b2197 Compare April 4, 2019 18:04
@brunohkbx brunohkbx changed the title fix: Doesn't pass ...rest prop to TextInput component on Searchbar fix(appbar): does not pass any additional props to Searchbar component Apr 4, 2019
@brunohkbx
Copy link
Copy Markdown
Collaborator Author

brunohkbx commented Apr 4, 2019 •
edited
Loading

Hey @satya164 @Trancever. My initial approach was to remove the ...rest props passed to TextInput, but there are some meaningful cases like passing autoFocus.
Thus, I just have checked if the children are a searchbar.
What do you guys think?

@jayu
Copy link
Copy Markdown
Contributor

jayu commented Apr 15, 2019

Hi @brunohkbx! Thank you for your interest in this issue. I've checked your solution and I think we can do it better. Please check my comment.
Let me know if you have time for changing your PR or I will handle this

jayu
jayu suggested changes Apr 15, 2019
View reviewed changes
Comment thread src/components/Appbar/Appbar.js Outdated
@brunohkbx
Copy link
Copy Markdown
Collaborator Author

brunohkbx commented Apr 15, 2019

Thanks for reviewing the changes @jaysbytes. I've already pushed your suggestions. 😁

@jayu
Copy link
Copy Markdown
Contributor

jayu commented Apr 15, 2019

Now the fix looks legit. WDYT @Trancever, can we merge?

@jayu jayu merged commit d95bb8b into callstack:master Apr 16, 2019
@brunohkbx brunohkbx deleted the fix/search-bar branch April 16, 2019 11:00
@brunohkbx brunohkbx mentioned this pull request Apr 17, 2019
Merged
jbinda pushed a commit to jbinda/react-native-paper that referenced this pull request Apr 17, 2019
@brunohkbx @jbinda
fix(appbar): do not pass any additional props to custom children comp…
337badc 
…onents (callstack#972)
iyadthayyil pushed a commit to iyadthayyil/react-native-paper that referenced this pull request Jun 6, 2019
@brunohkbx @iyadthayyil
fix(appbar): do not pass any additional props to custom children comp…
a15a47c 
…onents (callstack#972)
@iyadthayyil iyadthayyil mentioned this pull request Jun 14, 2019
Closed
Trancever pushed a commit that referenced this pull request Jun 27, 2019
@brunohkbx @Trancever
fix(appbar): do not pass any additional props to custom children comp…
446ad94 
…onents (#972)
@fabian-astorga fabian-astorga mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jayu jayu jayu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jayu jayu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Searchbar crashes on Android when wrapped in Appbar

3 participants

@brunohkbx @callstack-bot @jayu