fix: android slider seek时与viewPager 滑动冲突 #268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello, thanks for your contribution. Please translate comments in code to English & fill the description of pull request. |
Author
|
OK， I have done. |
Contributor
|
Hi @huaihong1986, The description of merge request is empty. Here is exemplary mr with description
|
| if (getParent() != null) { | ||
| try { | ||
| getParent().requestDisallowInterceptTouchEvent(true); | ||
| //SeekBar 放在其他视图中，手指放在 SeekBar 上面不会立即触发滑动操作 |
Member
There was a problem hiding this comment.
The code should always be self-explanatory.
If comments are required for the code to be more understandable they should be written in English.
Applies also to line 239.
| dispatchTouchEvent(evup); | ||
| evup.recycle(); | ||
| } | ||
| } catch (Exception exception) { |
Member
There was a problem hiding this comment.
Why leaving an empty exception here?
| public boolean onTouchEvent(MotionEvent event) { | ||
| //设置父容器不拦截事件 | ||
| if (getParent() != null) { | ||
| try { |
Member
There was a problem hiding this comment.
What exceptions do we expect here to be thrown by MotionEvent?
getParent() is already checked against null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: