Fix minimumTrackImage, maximumTrackImage, and trackImage do not work together #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix deps not linked on iOS. Fix installation problem with detox. * Updated config.yml Co-authored-by: Dmitry Stadnik <dstdnky@gmail.com>
michalchudziak
requested changes
Apr 7, 2021
src/ios/RNCSlider.h
Outdated
| @property (nonatomic, strong) UIImage *thumbImage; | ||
| @property (nonatomic, assign) bool tapToSeek; | ||
| @property (nonatomic, assign) bool minimumTrackImageSet; | ||
| @property (nonatomic, assign) bool maximumTrackImageSet; |
There was a problem hiding this comment.
I don't think we should make these public - let's keep them private.
…der into fix-issue-271
src/ios/RNCSlider.m
Outdated
| float _unclippedValue; | ||
| } | ||
| bool _minimumTrackImageSet; | ||
| bool _maximumTrackImageSet;} |
There was a problem hiding this comment.
nit: let's move the bracket to the next line
michalchudziak
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing issue #271 only for iOS.
Behavior after fix:
trackImagetrackImageandminimumTrackImagetrackImageandmaximumTrackImagetrackImage andminimumTrackImageandmaximumTrackImage`Test Plan:
Manually tested with other properties - works as before the changes.