fix: record real completion date on materialized occurrences - #2129
Merged
callumalpass merged 3 commits intoAug 1, 2026
Merged
Conversation
Completing a materialized occurrence wrote the occurrence date (occurrence_date) into completedDate, losing the actual completion date. The parent's complete_instances already tracks which occurrence was fulfilled, so completedDate can record when the user actually completed it — matching non-recurring task behavior. Fixes callumalpass#2125 (callumalpass/tasknotes) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2125
Problem
Completing a materialized occurrence writes the occurrence date (
occurrence_date) into the occurrence note'scompletedDate— the same value as scheduled/due — losing the date the user actually completed it. Non-recurring tasks record the real current date.Fix
TaskService.getCompletionDateForTask()returnedtask.occurrence_date || getCurrentDateString(). It now always returnsgetCurrentDateString(), matching non-recurring behavior.Which occurrence was fulfilled is still fully tracked:
buildMaterializedOccurrenceCompletePlan(in@tasknotes/model) appends the occurrence date to the parent'scomplete_instancesindependently, and that path is untouched.Testing
task-occurrence-materialization.test.ts: the occurrence'scompletedDateis now the (mocked) current date, while the parent'scomplete_instancesstill receives the occurrence date. Suite passes.completedDate: 2026-07-17; parent gotcomplete_instances: [2026-07-10, 2026-07-11]; scheduled advanced and the next occurrence materialized normally.🤖 Generated with Claude Code