Fix occurrence notes which don't have today's date - #2175
Merged
callumalpass merged 10 commits intoAug 1, 2026
Merged
Conversation
- When scheduled dates are in the future - When the scheduled date has changed from the recurrence date - Keeps due date relative to the recurrence (DTSTART) date - When scheduled dates are in the future but before the next recurrence
2064 recurrence fixes
@tasknotes/model now accepts an explicit completionDate so that completing a materialized occurrence under recurrence_anchor: completion advances the parent using when it was actually completed, not the occurrence's identity date. Requires an @tasknotes/model release that includes this field to take effect. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…occurrence_date. getCompletionDateForTask preferred occurrence_date over the real completion date whenever it was present, which is exclusively the case for materialized occurrence notes - so completing one always recorded completedDate as the occurrence's identity date instead of when it was actually marked done. Removed the helper and call getCurrentDateString() directly in updateProperty, matching how completedDate works for every other task. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts: # src/core/recurrence.ts # src/services/TaskService.ts # src/services/task-service/taskRecurringPlanning.ts # tests/unit/issues/issue-2064-dynamic-scheduled-dates-completion.test.ts
Owner
|
Thanks @chmac — excellent catch, and the linked regression made the failure easy to pin down. I’ve updated the model change so occurrence history remains keyed by occurrence_date while completion-anchored progression uses the real completion date, published the corrected model release, rebased this onto current main, and added end-to-end coverage plus the unreleased entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is dependent on this PR in the model repo: callumalpass/tasknotes-model#8
It makes a minor change to leverage that PR.
Same disclaimer applies, I've read the code, and it works for me locally, I'm running it on my vault, but I don't know your codebase well enough to make any statements about its quality.
theoretically fixes #2173