Exclude cancelled TODOs from checklist progress bar - #2183
Open
ctrl-q wants to merge 1 commit into
Open
Conversation
Cancelled inline checklist items (- [-]) were being counted toward the progress bar's denominator but never the numerator, making tasks with cancelled items appear less complete than they actually are (e.g. 1 done + 1 cancelled showed as 1/2 instead of 1/1). Cancelled items are now excluded entirely from both the numerator and denominator of the checklist progress calculation. Fixes callumalpass#2182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2182
Cancelled inline checklist items (
- [-]) were being counted toward the checklist progress bar's denominator, but never its numerator. This made tasks with cancelled TODO items appear less complete than they actually are.Example from the issue: a task with one
- [x](completed) and one- [-](cancelled) item showed1/2in the progress bar, when it should show1/1since the cancelled item shouldn't count at all.Changes
src/ui/taskCardProperties.ts: IncalculateChecklistProgress, skip list items whose marker is-(cancelled) before incrementingtotal, so cancelled items are excluded from both the numerator and denominator.tests/unit/issues/issue-1576-display-progress-bar.test.ts:-(e.g./), since-is no longer treated as merely "incomplete."-) items are excluded from both numerator and denominator (1 done + 1 cancelled→1/1, 100%).Testing
npx jest tests/unit/issues/issue-1576-display-progress-bar.test.ts— all 6 tests pass.src/releaseNotes.tsfile not being present outside of the build process).npx eslint src/ui/taskCardProperties.ts --max-warnings=0— clean.