fix: resolve issues #20, #21, #22, #23, #24 - #25
Merged
Conversation
- #20: Move Jellyfin API token from query string to X-API-Key header; document Plex token-in-URL as known limitation - #21: Redirect error/diagnostic fmt.Printf calls to stderr in internal/requests/requests.go - #22: Add shared DoRequest/DoJSON/DoXML helpers to internal/http/client.go; refactor all fetchers in streams, calendar, and feed packages to use them - #23: Add consistent CLI flag validation across all 4 tools; call config.Validate() at startup; fix arr-feed println to stderr - #24: Add godoc comments to all exported types, constants, and functions across all internal packages (http, config, streams, calendar, requests, feed) Closes #20, #21, #22, #23, #24
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch fix for 5 open issues and one follow-up (issue #8 closed as superseded).
Changes
Issue #20 — API tokens in query strings
api_keyfrom URL query param toX-API-KeyheaderIssue #21 — Error messages to stdout
fmt.Printferror/diagnostic calls ininternal/requests/requests.gowithfmt.Fprintf(os.Stderr, ...)Issue #22 — HTTP response handling boilerplate
DoRequest,DoJSON,DoXMLmethods tointernal/http/client.gointernal/streams/,internal/calendar/,internal/feed/to use shared helpersIssue #23 — Inconsistent CLI validation
-serverenum validation to media-streams-days/-days-past/-filtervalidation to media-calendar-urlnon-empty check to media-requests-events/-pollvalidation to arr-feedconfig.Validate()at startuparr-feedusingprintlninstead of stderrIssue #24 — Missing godoc comments
internal/http,internal/config,internal/streams,internal/calendar,internal/requests,internal/feedIssue #8 — Closed as superseded by config overhaul (PRs #18, #19)
Files changed: 13
Verification
go build ./...— passesgo test ./...— all tests passgo vet ./...— passesCloses #20, #21, #22, #23, #24