Fix CAMARA validation warnings from Actions run 30633755325 - #66
Merged
JoseMConde merged 1 commit intoJul 31, 2026
Merged
Conversation
- [P-016] Add writeOnly: true to AccessTokenCredential.accessTokenType. Every other CAMARA API defining this same Commonalities-derived schema (SimSwap, DeviceLocation, QualityOnDemand) already marks it writeOnly; this repo's copy was missing it. - [S-040] Document the x-correlator response header on the 7 response objects that didn't declare it: the 5 custom '409 Conflict' error responses (submitApp, deleteApp, createAppInstance, createAppDeployment, updateAppDeployment) and the 2 top-level '204' responses (deleteApp, deleteAppInstance). The callback '204' responses already documented it and were left untouched. - [S-313] No change. Verified all 15 hints against the current spec: they fall into the same categories already justified in camaraproject#46 for the r1.2 release review (name-like fields, version-like fields, and other intentionally free-form/opaque strings such as bearer tokens, usernames, and filesystem paths). Adding a regex pattern to any of them would impose an artificial restriction not required by the API and reduce interoperability. Leaving undocumented here per the same rationale; no new issue needed since it's the same precedent.
DLondonoD
requested review from
FabrizioMoggio,
JoseMConde,
Kevsy,
gainsley,
maheshc01 and
seralogar
as code owners
July 31, 2026 13:56
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Fixes the CAMARA Validation warnings reported in Actions run #30633755325 (https://github.
com/camaraproject/EdgeApplicationManagement/actions/runs/30633755325):
writeOnly: truetoAccessTokenCredential.accessTokenType. Every other CAMARA API sharing thissame Commonalities-derived schema (SimSwap, DeviceLocation, QualityOnDemand) already marks this field
writeOnly; thisrepo's copy was missing it, exposing a secret-classified field in responses.
x-correlatorresponse header on the 7 response objects that didn't declare it: the 5custom
409 Conflicterror responses (submitApp,deleteApp,createAppInstance,createAppDeployment,updateAppDeployment) and the 2 top-level204responses (deleteApp,deleteAppInstance).The remaining 15
[S-313]hints (free-form/implementation-dependent strings without aformat/pattern/enum) werereviewed and intentionally left unchanged, following the same precedent already established in #46. Rationale documented
in #65.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
No behavioral/runtime change — this only corrects the API definition to match the validator's mandatory rules
(
writeOnlyon secret fields,x-correlatorheader documentation on all responses). See # for therationale on the S-313 hints left unresolved.
Changelog input
release-note Add writeOnly to AccessTokenCredential.accessTokenType and document the x-correlator response header on
409/204 responses, per CAMARA validation warnings.
Additional documentation
This section can be blank.
docs