docs: link the review's open findings to their trackers - #63
Merged
Conversation
The resolution note said L7, L8, and the architectural observations were still open without saying where to follow them, which is the same kind of drift the review's own L1 finding was about. Points each at its issue, and records why two of the observations need no tracker: getTtl()'s first-layer semantics are documented now, and the envelope-expiry duplication was largely resolved when #56 made that check advisory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MsFZHTnQmAUMjtLUegFRPL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 695 695
Branches 167 167
=========================================
Hits 695 695
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-paragraph edit to
ARCHITECTURE_REVIEW.md. Follows filing #58–#62.The resolution note said L7, L8, and the architectural observations were "still open" without saying where to follow them — which is the same drift the review's own L1 finding was about. It now points each at its issue:
It also records why the remaining two observations need no tracker:
getTtl()'s first-layer-wins behavior is documented in the API reference as of #56, and the envelope-expiry duplication was largely resolved when #56 made that check advisory rather than load-bearing.No code, config, or other docs touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MsFZHTnQmAUMjtLUegFRPL