Use parameterized test for CamelCatalogVersionTest#795
Use parameterized test for CamelCatalogVersionTest#795apupier wants to merge 1 commit intocamel-tooling:mainfrom
Conversation
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
joshiraez
left a comment
joshiraez
left a comment
There was a problem hiding this comment.
Similar thing to what I said #792 although I don't think we need to go on a full TDD way in this file, it would still be useful that the data structure holding the information has all the information of the unit test and can be read at a glance
This way, we are losing a lot of valuable information in my opinion, just to avoid a bit of code duplication which I feel is not bad as they are different use cases at heart
| void testCompletionWithCatalog3xVersionLoaded() throws Exception { | ||
| camelCatalogVersion = "3.0.0-RC3"; | ||
| @ParameterizedTest | ||
| @ValueSource(strings = {"2.23.4", "3.0.0-RC3", "2.23.2.fuse-7_11_0-00037-redhat-00001"}) |
There was a problem hiding this comment.
Without labels to understand what each string tests I really feel like we lose a ton of valuable information and, in case the test fails, it won't help us understand at all that each one is a different use case.
There was a problem hiding this comment.
Each parameter is seen as a different test in the result.
There was a problem hiding this comment.
with the screenshot of the corresponding tests:
2 participants
No description provided.