fix: include actual error message in replaceable event rejection responses#711
Open
Priyanshubhartistm wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 1cf5ded The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ReplaceableEventStrategy.execute()sent clients a hardcodederror:command result (trailing space, no message) whenevereventRepository.upsert()rejected for any reason other than a duplicate event id constraint violation. The caughterror.messagewas never included in the response. The command result now includeserror.message, e.g.error: connection refused.Related Issue
#710
Motivation and Context
Clients receiving
["OK", "<id>", false, "error: "]have no actionable information about why their event was rejected, which makes debugging relay-side failures (DB outages, connection issues, etc.) unnecessarily difficult for client authors and relay operators.How Has This Been Tested?
pnpm run test:unit— 1483 passing.pnpm run test:cli— 73 passing.pnpm run cover:unit— passing.pnpm run docker:test:integration— 99 scenarios / 489 steps passing.pnpm run lint,pnpm run check:deps,pnpm run build:check,pnpm run build,pnpm run verify:cli:buildall pass.Screenshots (if appropriate):
N/A — backend WebSocket message content change only.
Types of changes
Checklist: