Skip to content

Added dlib::pipe<> to the benchmark#228

Merged
cameron314 merged 6 commits into
cameron314:masterfrom
pfeatherstone:master
Nov 10, 2020
Merged

Added dlib::pipe<> to the benchmark#228
cameron314 merged 6 commits into
cameron314:masterfrom
pfeatherstone:master

Conversation

@pfeatherstone

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread benchmarks/dlibqueue.h
@cameron314

Copy link
Copy Markdown
Owner

Is there any way to add just dlib::pipe without 1000 more files?

@cameron314

Copy link
Copy Markdown
Owner

Integration into the benchmarks looks good, though the LICENSE needs updating to mention explicitly that dlib::pipe is under the Boost license.

@pfeatherstone

Copy link
Copy Markdown
Contributor Author

Is there any way to add just dlib::pipe without 1000 more files?

I've removed a bunch of files. So it's a bit thinner.

@pfeatherstone

Copy link
Copy Markdown
Contributor Author

Integration into the benchmarks looks good, though the LICENSE needs updating to mention explicitly that dlib::pipe is under the Boost license.

You already have the boost license in LICENSE.MD. Am I missing something? Sorry, my knowledge of software licensing is very limited.

@cameron314

cameron314 commented Nov 10, 2020

Copy link
Copy Markdown
Owner

You already have the boost license in LICENSE.MD. Am I missing something? Sorry, my knowledge of software licensing is very limited.

I can only license my own code, not others'. So I'm careful to identify in the LICENSE file which parts are third party components that are licensed separately (even if it happens that their license is compatible).

Just a simple addition to the first paragraph would do. If you prefer, I can add it myself, just let me know. Apart from that the PR looks ready to merge.

@pfeatherstone

Copy link
Copy Markdown
Contributor Author

@cameron314 If you don't mind doing the licensing bit, that would be great. Thank you

@pfeatherstone

Copy link
Copy Markdown
Contributor Author

Next up is, https://github.com/max0x7ba/atomic_queue

@cameron314
cameron314 merged commit f0b3de0 into cameron314:master Nov 10, 2020
cameron314 added a commit that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants