Fix CMake deprecation warnings and include paths (fixes #384, #391, #432)#455
Open
NITIN9181 wants to merge 2 commits into
Open
Fix CMake deprecation warnings and include paths (fixes #384, #391, #432)#455NITIN9181 wants to merge 2 commits into
NITIN9181 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves three open CMake-related issues:
Fixes Deprecation warnings when building with newer versions of CMake #432 (CMake deprecation warnings): Updates
cmake_minimum_requiredto use the policy range syntax (VERSION 3.9...3.31). This silences the CMake deprecation warnings (e.g., "Compatibility with CMake < 3.10 will be removed") that occur in newer CMake versions, without breaking backward compatibility for users still on CMake 3.9.Fixes CMakeLists INSTALL DESTINATION and INSTALL_INTERFACE are inconsistent #384 and Consider reviewing the include path for a CMake install #391 (Mismatched include paths): Modifies the CMake install destination from
${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}/moodycamelto strictly${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}. This ensures that the physical installation path matches theINSTALL_INTERFACEexpectations. Downstream projects usingfind_packagewill now correctly resolve#include <concurrentqueue.h>without needing the inverted/moodycamel/subdirectory prefix, which also aligns with vcpkg compatibility.Both changes have been locally tested via
find_packageandFetchContentand compile cleanly.