Conversation
- Also move vi/edit and sleep to basic.js so they live on
- Tweak the text - Introduce an 'intro' command to display it again - Tweak the shortcut styling - Make the entire message hide when 'Got it' is pressed not just the button - Add createView to context so commands dont need to use require
- Demo of ways of specifying l10n text - Leave bugz command out of demo set until we fix it - Document that exec the return value might change shape
Anyone using our code as an example of how to write commands should be directed to use gcli.addCommand rather than canon.addCommand. The 'real' function is attached to canon, however we want to keep canon as private as we can, and encourage the exported use of gcli.addCommand instead.
This is the first in a number of changes. We generally use undefined to mean 'missing value' and 'null' to mean deliberately set to nothing. For example setting param.defaultValue=null means the user doesn't need to specify a value on the command line. So it makes sense to use undefined as the default value for conversions rather than null.
- Properly extract defaultValues from paramSpec to Parameter - The concept of getDefault goes and is replaced by setting up defaultValue to getBlank by default - use of defaultValue is moved to 'final read point' i.e. getArgsObject - A number of tests are updated
- Allows us to encapsulate the special 'isBlank' treatment - Also fix Resource type not actually using 'id'
- Remove un-needed stuff - Add returnTypes to commands
- Fix console logging command name - Allow users to see if the command resulted in a promise
This is just a 'stop it crashing' fix: - Remove pref command. It's too slow - Update console to work with web console
- 3 tests to check for places when it's right to stop propagation - Removed default setter call, because the correct value is later used
The event was called assignmentValueChanged to distinguish it from the assignmentChanged event which is called when the caret moves into a new assignment. But Assignments have arguments and values, and we're now bailing out if the value did not change. so the assignmentValueChanged was confusing.
The new version creates predictions
They now switch between the options. Previously it auto-completed. This is more key-presses, but more obvious.
JSD gets confused about executable lines with 'case null:'
- types can do more with predictions - it's more encapsulated - continues work begin in 9522a83
- Just like all the other types
- Previously we had this basic idea a level up and it was hacky - We should extend this idea to remove _structuralChangeInProgress but that can wait for another day
- Inputter should use an specific cursor position because:
element.selectionStart = 4;
console.log(element.selectionStart);
// could be non-4 until event loop re-joined
This latter bug only exposed due to an experiment in removing a XUL bug
workaround
- Tooltip should compare arg.text not value because it deals with text
- Both times we mess with an argument we need to make sure its there - Also minor doc tweak
- Requested by Orion integration
Don't die when there is no document
- Previously we needed this timeout, but it seems now we dont - If this sticks we should close bug 676520
- We stopped using meta-bugs for milestones, so this broke - Now it's a single level thing we can use a table - Use a view rather than DOM hackery
- importCss can not generate an id from hash(cssText) to prevent multiple additions of same cssText - createView now supports css and cssId for passing to importCss - This is used to simplify help.js
- We should check whenever we update - We should update even when output are hidden - Tests should reflect these changes
- Move to view - Add 'hidden' option to prevent messing up output
- replace line delimitting with margin delimitting
- Also 2 minor code tidy-ups (unused require and better jsdoc)
- Also remove un-needed require (fields.js) - And add missing event un-register (basic.js)
- Move 'test' command to test/commands/test.js from test/commands.js - Document the options passed to a test run - Handle default options better - Pass 'display' into tests rather than components individually - Log errors to 'test' command more verbosely - Handle failures during setup
- They were not logical, and causing test confusion
Changes along with these added tests: - Added inputter.setCursor() function to help cursor position testing - Added requistion.typedEndsWithWhitespace() - See jsdoc comments - SelectionType._findPredictions skips non-exact matches when the argument looks like it's "done". - blank Booleans are textless, VALID and have predictions - Separate tabText into directTabText (i.e. what's displayed at the cursor) and arrowTabText (i.e. what's displayed at the end of the line) - Simplify emptyParameter handling
- Log via test-suite rather than via console - Remove unused reportToText function - Improve docs
- Include count of checks passed and overall status - Trim common prefix from suite names - Error messages display properly - Minor style updates to HTML output and text output
- We should set it by default.
- Testing demonstrated that they were not being used
- New suite for tooltip testing - More tests for keyboard usage - More cli tests - New command for deeply nested sub commands - Added logging given new test.log ability
Owner
|
r+ for (gclidocs) and (intro) |
Owner
|
r+ on (default) and (toolbar) |
Owner
|
r+ (noopts) |
Owner
|
r+ (fulltab) |
Owner
|
r+ (ontense) (underscore) (cleanout) |
Owner
|
r+ (view) |
Owner
|
r+(moretests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.