fix: align GLOBAL_FLAGS unit test with limit removal#108
Merged
vobu merged 2 commits intorefactor/search-feedbackfrom Feb 27, 2026
Merged
fix: align GLOBAL_FLAGS unit test with limit removal#108vobu merged 2 commits intorefactor/search-feedbackfrom
vobu merged 2 commits intorefactor/search-feedbackfrom
Conversation
Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unknown flag detection and enhance search result messaging
fix: align GLOBAL_FLAGS unit test with limit removal
Feb 27, 2026
vobu
added a commit
that referenced
this pull request
Feb 27, 2026
…aging (#106) (ping back to camunda/product-hub#2638 for ref) * feat: implement unknown flag detection and enhance search result messaging * chore: update src/commands/search.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: update src/commands/search.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: align GLOBAL_FLAGS unit test with limit removal (#108) * Initial plan * fix: update GLOBAL_FLAGS test to reflect limit removal from global flags Co-authored-by: vobu <6573426+vobu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vobu <6573426+vobu@users.noreply.github.com> * fix: correct version property reference in main function * feat: export API_DEFAULT_PAGE_SIZE and enhance log functions for better feedback * fix: improve CLI invocation handling with realpathSync for symlink resolution * test: add integration tests for global install and symlink invocation * fix: update symlink handling in integration tests for clarity and accuracy * fix: skip global-install tests gracefully when dist/index.js is absent (#109) * Initial plan * fix: skip global-install tests when dist/index.js is absent (CI fix) Co-authored-by: vobu <6573426+vobu@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vobu <6573426+vobu@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
limitwas correctly removed fromGLOBAL_FLAGS(it's only valid forsearch variable), the unit test still assertedGLOBAL_FLAGS.has('limit'), breaking CI.Changes
tests/unit/search-feedback.test.ts: Remove the staleGLOBAL_FLAGS.has('limit')assertion; replace with an explicit negative test documenting thatlimitis intentionally absent from global flags and scoped only toSEARCH_RESOURCE_FLAGS['variable']💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.