feat: move images from connector-runtime-docker repository#804
feat: move images from connector-runtime-docker repository#804chillleader merged 4 commits intomainfrom
Conversation
chillleader
added
scope:runtime
ci/cd
chillleader
requested review from
Oleksiivanov,
igpetrov,
markfarkas-camunda and
sbuettner
| fi | ||
|
|
||
| exec java "${JAVA_OPTS}" -cp '/opt/app/*' io.camunda.connector.bundle.ConnectorRuntimeApplication | ||
| unzip -l /opt/app/connector-runtime-application-0.21.0-SNAPSHOT-with-dependencies.jar | grep ConnectorRuntimeApplication |
There was a problem hiding this comment.
Will this version (connector-runtime-application-0.21.0-SNAPSHOT-with-dependencies) be automatically updated by our maven plugin or will we have to manage it manually?
There was a problem hiding this comment.
Sorry, this is a debug artifact - I removed this line
|
@chillleader How would one launch the self-managed version with all connectorswithout building a docker image? Just search for the |
|
@sbuettner You can still use the docker image from the default-bundle module, as we continue to publish it on DockerHub. Sorry if it's confusing from the description. I meant that we stop publishing this image which was previously built from the example dockerfile. |
|
@chillleader Sorry, I wasnt clear enough. I meant just launching the whole bundle with all dependencies from the IDE. |
|
Yeah then it's exactly like you described, navigate to the main class in |
| RUN chmod +x start.sh | ||
|
|
||
| # Copy Connector runtime from local build | ||
| COPY target/*-with-dependencies.jar /opt/app/ |
There was a problem hiding this comment.
Maybe it even makes sense to simplify it to *.jar. WDYT?
There was a problem hiding this comment.
This way the non-executable slim jar will also make it to the docker image.I think it makes sense to keep the classpath clean and only add the needed files
igpetrov
left a comment
igpetrov
left a comment
There was a problem hiding this comment.
LGTM, several optional suggestions
3 participants
Description
This PR incorporates Docker images that were previously managed in connector-runtime-docker repository. I have also adjusted a few things regarding project structure and what images we publish - please take a look below and I'm open to feedback! 🙂
Changes to project structure
New directory is created to manage the minimal viable version the connector runtime:
/connector-runtime/connector-runtime-application. This is aligned with our modular approach, as we previously shipped the runtime inspring-boot-starter-camunda-connectorsand inbundleversions. Spring Boot starter is not a standalone Java app, and bundle comes with OOTB connectors, so there was no middle ground (viable standalone runtime without any connectors).In this PR, the minimal runtime is shipped in 2 forms: Maven module
connector-runtime-applicationand Docker image camunda/connectors.With this change, the structure of the
/bundle/default-bundlemodule was slightly adjusted. It doesn't have its own@SpringBootApplicationclass anymore. Instead, it reuses the one defined in the new module,connector-runtime-application. Accordingly, thesrcdirectory ofdefault-bundleis deleted.Dockerfiles moved to this repo
/connector-runtime/connector-runtime-application/Dockerfile- base image for connector runtime, no connectors included. See DockerHub./connector-runtime/connector-runtime-application/example/Dockerfile- an example Dockerfile that illustrates how one can create a custom connectors bundle in a pure docker setup.default-bundleimage. We continue to maintain it as an example for custom builds.Build pipeline changes
camunda/connectorsbase image from the new module in ourDEPLOY.mdpipelineRELEASE.mdpipelineRelated issues
related to #538