Skip to content

Improve Stall Console and Selection UI#77

Merged
candour merged 1 commit into
mainfrom
ui-tweaks-stall-selection-1144089786692969629
Apr 23, 2026
Merged

Improve Stall Console and Selection UI#77
candour merged 1 commit into
mainfrom
ui-tweaks-stall-selection-1144089786692969629

Conversation

@candour

@candour candour commented Apr 23, 2026

Copy link
Copy Markdown
Owner

This PR improves the UI for stall management and selection:

  1. In the selected stall console, upgrade stats are now vertically aligned with base stats, and the "Fed" counter has been renamed to "People Fed".
  2. In the stall selection list, stall icons are 20% larger, names are larger and black with wrapping, and costs are larger with distinctive shadows and updated colors for better legibility.

PR created automatically by Jules for task 1144089786692969629 started by @candour

Summary by CodeRabbit

  • Style
    • Improved upgrade benefit display formatting for better readability.
    • Updated stall name styling with larger, clearer text and multi-line support.
    • Enhanced cost text with color-coded affordability indicators (green for affordable, red otherwise) and bold styling.
    • Added visual emphasis through drop shadows on cost indicators.
    • Increased stall icon size for better visibility.
    • Changed label from "Fed" to "People Fed" for clarity.

- Align upgrade stats in StallConsole and rename 'Fed' to 'People Fed'.
- Increase icon size and style name/cost text in StallSlot.
- Add shadows to cost text for better visibility.

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cab2aff6-83e7-4c81-a897-7c33adaefff2

📥 Commits

Reviewing files that changed from the base of the PR and between 819f222 and 9df7531.

📒 Files selected for processing (2)
  • app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt
  • app/src/main/java/com/messark/hawker/ui/components/StallSlot.kt

📝 Walkthrough

Walkthrough

Two UI components are modified to update visual rendering. StallConsole refactors upgrade benefit display to use a structured StatLine component and changes "Fed" to "People Fed". StallSlot increases sprite canvas dimensions (24×32 to 29×39 dp), updates stall name styling to black text with larger font, and adds conditional color and shadow effects to cost text based on affordability.

Changes

Cohort / File(s) Summary
StallConsole upgrade rendering
app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt
Refactored upgrade benefit display to format value-only output via StatLine component with blue label/value colors; changed stat label from "Fed" to "People Fed".
StallSlot visual styling
app/src/main/java/com/messark/hawker/ui/components/StallSlot.kt
Increased sprite canvas size (24×32 to 29×39 dp); updated stall name to black, larger font (12.sp); added conditional cost text styling with green color when affordable, red otherwise, bold weight, and conditional drop shadows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Improve Stall Console and Selection UI' accurately and directly reflects the main changes: updates to both the stall console component and stall selection UI with specific visual improvements mentioned in the PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ui-tweaks-stall-selection-1144089786692969629

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour
candour merged commit 84c1bb3 into main Apr 23, 2026
3 checks passed
@candour
candour deleted the ui-tweaks-stall-selection-1144089786692969629 branch April 23, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant