docs: populate charm documentation#6
Merged
Conversation
…-documentation-ISD-4194
florentianayuwono
added
the
documentation
erinecon
reviewed
Sep 17, 2025
erinecon
left a comment
erinecon
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for adding so much documentation in this PR! I've only gone through a couple of the pages so far -- here's a first round of comments from me. Let me know if you have any questions!
erinecon
reviewed
Sep 17, 2025
erinecon
left a comment
erinecon
left a comment
Contributor
There was a problem hiding this comment.
Here are some suggestions on the second half of the documents (plus some suggestions to fix some of the Vale errors)
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
erinecon
reviewed
Sep 22, 2025
erinecon
left a comment
erinecon
left a comment
Contributor
There was a problem hiding this comment.
The documentation is looking great! Another round of comments from me
Co-authored-by: Erin Conley <erin.conley@canonical.com>
erinecon
reviewed
Sep 23, 2025
Co-authored-by: Erin Conley <erin.conley@canonical.com>
erinecon
reviewed
Sep 24, 2025
erinecon
left a comment
erinecon
left a comment
Contributor
There was a problem hiding this comment.
The documentation looks great! Non-blocking nitpicks only :D
Unless you're planning to add new documentation pages into this PR, I'm ready to approve. Let me know what the next steps are for this PR!
erinecon
approved these changes
Sep 24, 2025
Co-authored-by: Erin Conley <erin.conley@canonical.com>
erinecon
reviewed
Oct 8, 2025
erinecon
left a comment
erinecon
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding a new how-to guide -- it's extremely useful information to document :D
Co-authored-by: Erin Conley <erin.conley@canonical.com>
weiiwang01
approved these changes
Oct 10, 2025
Co-authored-by: Weii Wang <weii.wang@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec: ISD249 - Aproxy Subordinate Charm
Note to reviewer: please only consider docs changes, other changes will be reviewed in PR #4
Overview
Add relevant documentations required for releasing charm
Rationale
Part of Aproxy Charm release
Juju Events Changes
None
Module Changes
None
Library Changes
None
Checklist
urgent,trivial,senior-review-required,documentation)docs/changelog.mdis updated with user-relevant changes.No need for docs changes