Add panel backlight ramp monitor test (New)#2653
Merged
Merged
Conversation
baconYao
added
the
ce-oem
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CE-OEM “monitor” capability for built-in panel backlight testing by introducing a helper script that (a) enumerates /sys/class/backlight devices as Checkbox resources and (b) runs a 5-step brightness ramp test per device, with optional alias mapping via BACKLIGHT_PANEL_MAP.
Changes:
- Add a new manifest entry (
has_built_in_panel) and gate backlight jobs on it. - Add resource + templated user-interactive job units to enumerate backlight devices and test brightness ramp per panel.
- Add
bin/backlight_panel.pyimplementation plusunittestcoverage.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| contrib/checkbox-ce-oem/checkbox-provider-ce-oem/units/monitor/manifest.pxu | Adds a new manifest entry to indicate presence of a built-in display panel. |
| contrib/checkbox-ce-oem/checkbox-provider-ce-oem/units/monitor/jobs.pxu | Introduces resource enumeration and templated brightness ramp jobs (gated by the new manifest entry). |
| contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/backlight_panel.py | Implements backlight resource enumeration, optional alias mapping, and brightness ramp test logic. |
| contrib/checkbox-ce-oem/checkbox-provider-ce-oem/tests/test_backlight_panel.py | Adds unit tests for mapping parsing, record generation, brightness ramp behavior, and CLI handlers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seankingyang
requested changes
Jul 13, 2026
seankingyang
left a comment
seankingyang
left a comment
Contributor
There was a problem hiding this comment.
Please add these test case (also resource job ) into the test plan.
seankingyang
self-requested a review
July 13, 2026 07:50
Introduce a new backlight panel helper with two subcommands: resource to enumerate backlight devices for Checkbox resource records, and test to ramp brightness across five levels and verify each step. Support optional alias mapping via BACKLIGHT_PANEL_MAP so generated jobs can use stable panel names while targeting the real sysfs device. Add monitor units to: expose backlight devices as resources, generate per-panel user-interact-verify jobs, and gate execution on a built-in panel manifest entry. Signed-off-by: baconYao <patrick.chang@canonical.com>
baconYao
force-pushed
the
land-monitor-in-ce-oem
branch
from
July 13, 2026 09:02
42b8f63 to
0eb6fd5
Compare
stanley31huang
self-requested a review
July 13, 2026 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new backlight panel helper with two subcommands: resource to enumerate backlight devices for Checkbox resource records, and test to ramp brightness across five levels and verify each step.
Support optional alias mapping via BACKLIGHT_PANEL_MAP so generated jobs can use stable panel names while targeting the real sysfs device.
Resolved issues
Documentation
Tests