Skip to content

Hidden manifest entry for ignoring efi testing on the devices that does not have UEFI (New)#2722

Merged
Hook25 merged 1 commit into
mainfrom
efi-on-rpi
Jul 22, 2026
Merged

Hidden manifest entry for ignoring efi testing on the devices that does not have UEFI (New)#2722
Hook25 merged 1 commit into
mainfrom
efi-on-rpi

Conversation

@gntzio

@gntzio gntzio commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Description

RPIs boot using custom firmware rather then UEFI. This results that miscellanea/efi_boot_mode is constantly failing on that devices.
Hidden manifest _ignore_efi_boot_mode provides explicit leverage to ignore the test on a specific devices.

Resolved issues

CER-4095

Documentation

N/A

Tests

N/A

Copilot AI review requested due to automatic review settings July 22, 2026 15:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a hidden manifest entry to allow specific devices (e.g., Raspberry Pi systems that boot via board firmware rather than UEFI) to skip the miscellanea/efi_boot_mode job, preventing consistent failures on non-UEFI platforms while keeping the test enabled by default elsewhere.

Changes:

  • Introduce hidden manifest entry _ignore_efi_boot_mode (bool) with a documented hidden reason.
  • Gate miscellanea/efi_boot_mode execution on _ignore_efi_boot_mode == 'False' via a requires condition (with manifest import).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
providers/base/units/miscellanea/manifest.pxu Adds _ignore_efi_boot_mode hidden manifest entry to control whether EFI boot mode testing should be skipped.
providers/base/units/miscellanea/jobs.pxu Updates miscellanea/efi_boot_mode job requirements to honor the new manifest flag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gntzio
gntzio requested a review from Hook25 July 22, 2026 15:14

@Hook25 Hook25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks, don't forget to update the manifests in the repo

@Hook25
Hook25 merged commit bb3aac1 into main Jul 22, 2026
27 checks passed
@Hook25
Hook25 deleted the efi-on-rpi branch July 22, 2026 15:30
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.01%. Comparing base (1d98b32) to head (1b85772).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2722   +/-   ##
=======================================
  Coverage   60.01%   60.01%           
=======================================
  Files         487      487           
  Lines       48931    48931           
  Branches     8764     8764           
=======================================
  Hits        29368    29368           
+ Misses      18641    18638    -3     
- Partials      922      925    +3     
Flag Coverage Δ
provider-base 36.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants