Hidden manifest entry for ignoring efi testing on the devices that does not have UEFI (New)#2722
Conversation
…on the devices that does not have UEFI.
There was a problem hiding this comment.
Pull request overview
Adds a hidden manifest entry to allow specific devices (e.g., Raspberry Pi systems that boot via board firmware rather than UEFI) to skip the miscellanea/efi_boot_mode job, preventing consistent failures on non-UEFI platforms while keeping the test enabled by default elsewhere.
Changes:
- Introduce hidden manifest entry
_ignore_efi_boot_mode(bool) with a documented hidden reason. - Gate
miscellanea/efi_boot_modeexecution on_ignore_efi_boot_mode == 'False'via arequirescondition (withmanifestimport).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| providers/base/units/miscellanea/manifest.pxu | Adds _ignore_efi_boot_mode hidden manifest entry to control whether EFI boot mode testing should be skipped. |
| providers/base/units/miscellanea/jobs.pxu | Updates miscellanea/efi_boot_mode job requirements to honor the new manifest flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hook25
left a comment
There was a problem hiding this comment.
+1, thanks, don't forget to update the manifests in the repo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
=======================================
Coverage 60.01% 60.01%
=======================================
Files 487 487
Lines 48931 48931
Branches 8764 8764
=======================================
Hits 29368 29368
+ Misses 18641 18638 -3
- Partials 922 925 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
RPIs boot using custom firmware rather then UEFI. This results that
miscellanea/efi_boot_modeis constantly failing on that devices.Hidden manifest
_ignore_efi_boot_modeprovides explicit leverage to ignore the test on a specific devices.Resolved issues
CER-4095
Documentation
N/A
Tests
N/A