chore(rbxcloud): enable untyped function checks - #7043
Conversation
blackboxsw
left a comment
There was a problem hiding this comment.
Thank you for the contribution @Chan-Developer.
Ideally, we want to better type all functions within this module: get_md, get_manage_etc_hosts, gratuitous_arp, generate_network_config and read_user_data_callback. If we can better type the expected return value details from get_md, then we shouldn't have to use typing.cast.
93835a5 to
b6134a0
Compare
|
Thank you for the review. I replaced the |
b6134a0 to
987aada
Compare
987aada to
47dbe2a
Compare
|
@blackboxsw @holmanb All requested updates are now included in the latest commit, and I have resolved the corresponding outdated review threads. The full CI suite is green. When convenient, could you please take another look? Thank you. |
Proposed Commit Message
Additional Context
The structured return type from
get_mdnow flows intoself.cfg, allowingnetwork_configto be accessed withouttyping.cast. The activation guardalso reflects that gratuitous ARP data is unavailable until datasource data
has been successfully read.
Test Steps
Merge type