Skip to content

Update runner image to 24.04 - #59

Merged
paride merged 10 commits into
canonical:mainfrom
balcsida:chore/update-runner-image
Jun 25, 2026
Merged

Update runner image to 24.04#59
paride merged 10 commits into
canonical:mainfrom
balcsida:chore/update-runner-image

Conversation

@balcsida

Copy link
Copy Markdown
Contributor

This should also enable running all the tests that were skipped due to the old busybox

@balcsida
balcsida marked this pull request as draft October 31, 2024 21:07
@balcsida balcsida closed this Jul 2, 2025
@balcsida balcsida reopened this Dec 31, 2025
@balcsida
balcsida marked this pull request as ready for review December 31, 2025 00:25
@paride
paride requested a review from Copilot June 25, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates CI to run on Ubuntu 24.04 and refreshes the tox-pinned lint toolchain, with the intent of unblocking BusyBox-based tests that were previously skipped on older runner environments.

Changes:

  • Switch GitHub Actions runners from ubuntu-22.04 to ubuntu-24.04 and stop skipping mic/growpart in the BusyBox minimal-environment test step.
  • Update tox-pinned versions of flake8, pylint, and shellcheck-py.
  • Minor robustness/cleanup tweaks in scripts (context-manager file handling in write-mime-multipart, f-string formatting in ec2metadata, quoting an echo in a test script).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tox.ini Updates pinned linter/tool versions and flattens file lists used by flake8/pylint/shellcheck.
test/test-growpart Small shell quoting adjustment for consistent output.
bin/write-mime-multipart Uses context managers for file IO and refactors output writing into a helper.
bin/ec2metadata Converts several string interpolations to f-strings (including usage text).
.github/workflows/ci.yaml Moves CI runner to Ubuntu 24.04 and enables BusyBox tests previously skipped due to BusyBox age.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@paride paride left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit-by-commit, LGTM, thanks!

@paride
paride added this pull request to the merge queue Jun 25, 2026
Merged via the queue into canonical:main with commit cf50e0a Jun 25, 2026
2 checks passed
@balcsida
balcsida deleted the chore/update-runner-image branch June 25, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants