Update runner image to 24.04 - #59
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates CI to run on Ubuntu 24.04 and refreshes the tox-pinned lint toolchain, with the intent of unblocking BusyBox-based tests that were previously skipped on older runner environments.
Changes:
- Switch GitHub Actions runners from
ubuntu-22.04toubuntu-24.04and stop skippingmic/growpartin the BusyBox minimal-environment test step. - Update tox-pinned versions of
flake8,pylint, andshellcheck-py. - Minor robustness/cleanup tweaks in scripts (context-manager file handling in
write-mime-multipart, f-string formatting inec2metadata, quoting anechoin a test script).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tox.ini |
Updates pinned linter/tool versions and flattens file lists used by flake8/pylint/shellcheck. |
test/test-growpart |
Small shell quoting adjustment for consistent output. |
bin/write-mime-multipart |
Uses context managers for file IO and refactors output writing into a helper. |
bin/ec2metadata |
Converts several string interpolations to f-strings (including usage text). |
.github/workflows/ci.yaml |
Moves CI runner to Ubuntu 24.04 and enables BusyBox tests previously skipped due to BusyBox age. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paride
approved these changes
Jun 25, 2026
paride
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed commit-by-commit, LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should also enable running all the tests that were skipped due to the old busybox